After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780985 - Improve Todo.txt preference panel
Improve Todo.txt preference panel
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-06 17:52 UTC by Rohit Kaushik
Modified: 2017-04-08 01:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
todo.txt-plugin: Improve preferences panel (2.82 KB, patch)
2017-04-06 18:04 UTC, Rohit Kaushik
none Details | Review
todo.txt: improve preferences panel (2.82 KB, patch)
2017-04-08 01:28 UTC, Georges Basile Stavracas Neto
committed Details | Review

Description Rohit Kaushik 2017-04-06 17:52:33 UTC
Currently there is no way to see the todo.txt file selected.This can be fixed by using GtkFileChooserButton rather than a dailog.
Comment 1 Rohit Kaushik 2017-04-06 18:04:15 UTC
Created attachment 349391 [details] [review]
todo.txt-plugin: Improve preferences panel

Currently todo.txt uses GtkFileChooser Widget as preference panel
which allows user to select the todo.txt file.

The problem is GtkFileChooser has no option to show what todo.txt
file user has currently choosen, creating confusion and ambiguity.

The fix is to use a GtkFileChooserButton in a box as the preferences
panel, where the button displays the file user has already chosen
and hence preventing user from choosing the same todo.txt file again
and also it is lot more clear and meaningul than just a FileChooser
Dialog.
Comment 2 Georges Basile Stavracas Neto 2017-04-08 01:28:32 UTC
Created attachment 349512 [details] [review]
todo.txt: improve preferences panel

Fixed the commit message title
Comment 3 Georges Basile Stavracas Neto 2017-04-08 01:29:34 UTC
Thanks for the patch!

Attachment 349512 [details] pushed as 828276d - todo.txt: improve preferences panel