After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780908 - gobject: remove duplicate GType sanity check
gobject: remove duplicate GType sanity check
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-04-04 16:23 UTC by Tim-Philipp Müller
Modified: 2017-04-08 05:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gobject: remove duplicate GType sanity check (1.10 KB, patch)
2017-04-04 16:23 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2017-04-04 16:23:23 UTC
Created attachment 349246 [details] [review]
gobject: remove duplicate GType sanity check

As per discussion on IRC with ebassi.

This is going to be checked again by g_object_new_with_properties()
and g_object_new_valist() anyway, so might just as well leave it
to those functions to do the check and only do it once. It doesn't
matter which function emits the critical warning in the end either,
as one has to look at a stack trace to find out what code triggered
it in any case.
Comment 1 Matthias Clasen 2017-04-08 05:20:16 UTC
Review of attachment 349246 [details] [review]:

this looks good to me
Comment 2 Matthias Clasen 2017-04-08 05:20:45 UTC
Attachment 349246 [details] pushed as a83ccc5 - gobject: remove duplicate GType sanity check