GNOME Bugzilla – Bug 780867
rtpsession: send BYE after timeout only for internal sources that were the suggested_ssrc in the past
Last modified: 2018-11-03 15:17:49 UTC
Created attachment 349172 [details] [review] rtpsession: send BYE after timeout only for internal sources that were the suggested_ssrc in the past There is a logic in rtpsession to send BYE for internal sources that are inactive for a long time. This is basically done as an optimization, to remove stale sources that have been created in the past for internal reasons but are no longer in use (see bug 720440). However, previously, this logic would also affect retransmission sources. Rtx sources *can* be inactive for some time, for a very legitimate reason (no packet loss), but we shouldn't send BYE for them because they may still be used. They should stay around as receivers (as the RFC states for all inactive senders).
Created attachment 349340 [details] [review] tests/check/rtpsession: extend test_internal_sources_timeout to verify that rtx SSRCs do not BYE after timeout
I accidentally pasted this bug link on two unrelated commits. Leaving this comment here for people looking for the real bug ID: --- commit 21f532f1c66f27e1d097cab12a48b2763e0d93ac Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Fri Apr 7 16:33:18 2017 +0300 tests/check/rtprtx: add checks for rtprtxqueue's max-size-{time,packets} properties https://bugzilla.gnome.org/show_bug.cgi?id=780867 commit 7f6c7839301b7a13aae79b260deb4e619248d270 Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Tue Apr 4 17:33:31 2017 +0300 rtprtxqueue: implement handling of the max-size-time property https://bugzilla.gnome.org/show_bug.cgi?id=780867 --- It should have been https://bugzilla.gnome.org/show_bug.cgi?id=780904 Sorry!
Bump. Anyone to review?
Review of attachment 349172 [details] [review]: I think old sources could have other origines, I wonder if we can't instead have a way for the rtpsession to know which ones are the current rtx ssrcs ? Tempted to suggest adding "ssrcs=(list of uints)" to the caps so that multiple ssrcs can be put in there...
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/360.