After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780794 - gnome-tweak-tool 3.24 won't start if gnome-shell isn't running
gnome-tweak-tool 3.24 won't start if gnome-shell isn't running
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.24.x
Other Linux
: Normal major
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-01 05:06 UTC by 243750496
Modified: 2017-06-12 01:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test that gnome-shell is running before binding to the schema key (1.23 KB, patch)
2017-04-01 11:45 UTC, foss.freedom
needs-work Details | Review

Description 243750496 2017-04-01 05:06:14 UTC
atc@ATC:~$ gnome-tweak-tool
WARNING : Shell not installed or running
atc@ATC:~$ sudo gnome-tweak-tool
WARNING : Shell not installed or running

gnome-tweak-tool version 3.24


more addition:
i had installed freshly just before this fresh install, it working smoothly but i haven't check the version of gnome-tweak-tool at that time, so maybe it's a new version bug? or something else i did wrong at this time?
Comment 1 foss.freedom 2017-04-01 11:45:10 UTC
Created attachment 349111 [details] [review]
test that gnome-shell is running before binding to the schema key
Comment 2 Rui Matos 2017-04-10 13:06:43 UTC
Review of attachment 349111 [details] [review]:

thanks for the patch, but it needs to be changed a bit, see below

::: gnome-tweak-tool-3.24.0.orig/gtweak/tweaks/tweak_group_shell_extensions.py
@@ -308,3 @@
         self.titlebar_widget = Gtk.Switch(visible=True)
-        shell._settings.bind("disable-user-extensions", self.titlebar_widget,
-                             "active", Gio.SettingsBindFlags.INVERT_BOOLEAN)

It doesn't make sense to have a non-working switch in the titlebar though. Best thing to do is move these two statements up inside the big try: block after we're sure we have a working shell instance.
Comment 3 Ikey Doherty 2017-05-11 04:28:50 UTC
Note this issue is fixed within my other patches in:

https://bugzilla.gnome.org/show_bug.cgi?id=780794
Comment 4 Ikey Doherty 2017-05-11 04:29:41 UTC
OK hit the copy-paste cookie monster. Meant https://bugzilla.gnome.org/show_bug.cgi?id=781321

gg Bugzilla for no comment edit function :)
Comment 5 Jeremy Bicha 2017-05-26 19:34:03 UTC
Ikey, could you split your fix for this bug to a separate patch for GNOME 3.24?
Comment 6 Jeremy Bicha 2017-06-12 01:01:22 UTC
This problem has been fixed in our software repository. The fix will go into the next software release, 3.24.1. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.