After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780680 - progress-persistence-handler: port away from manual decls
progress-persistence-handler: port away from manual decls
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-29 11:14 UTC by Diana Grecu
Modified: 2017-03-29 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
progress-persistence-handler: port away from manual decls (8.32 KB, patch)
2017-03-29 11:14 UTC, Diana Grecu 		none Details | Review
progress-persistence-handler: port away from manual decls (8.21 KB, patch)
2017-03-29 11:31 UTC, Diana Grecu 		committed Details | Review

Description Diana Grecu 2017-03-29 11:14:28 UTC 
See patch.
Comment 1 Diana Grecu 2017-03-29 11:14:32 UTC 
Created attachment 348927 [details] [review]
progress-persistence-handler: port away from manual decls

This patch reduces the number of macros used to define the type,
by means of the macro G_DECLARE*, and improves the readability of code.
Comment 2 Razvan Chitu 2017-03-29 11:20:50 UTC 
Review of attachment 348927 [details] [review]:

::: src/nautilus-progress-persistence-handler.h
@@ +29,3 @@
 G_BEGIN_DECLS
 
+#define NAUTILUS_TYPE_PROGRESS_PERSISTENCE_HANDLER\

This line does not need to be changed.
Comment 3 Diana Grecu 2017-03-29 11:31:53 UTC 
Created attachment 348928 [details] [review]
progress-persistence-handler: port away from manual decls

This patch reduces the number of macros used to define the type,
by means of the macro G_DECLARE*, and improves the readability of code.
Comment 4 Razvan Chitu 2017-03-29 11:39:08 UTC 
Review of attachment 348928 [details] [review]:

LGTM, waiting for Carlos or Ernestas to take a look too.
Comment 5 Ernestas Kulik 2017-03-29 11:54:00 UTC 
Review of attachment 348928 [details] [review]:

LGTM as well, thanks, Diana!
Comment 6 Ernestas Kulik 2017-03-29 14:46:01 UTC 
Attachment 348928 [details] pushed as 54a3c21 - progress-persistence-handler: port away from manual decls
Comment 7 Ernestas Kulik 2017-03-29 14:49:54 UTC 
Congrats on your first contribution, Diana!