GNOME Bugzilla – Bug 780642
webrtcechoprobe: SIGFPE in case the webdsp element is activated before webrtcechoprobe
Last modified: 2017-03-29 13:49:34 UTC
Created attachment 348866 [details] [review] webrtcechoprobe: return from _read() early if the probe is not configured yet In case webdsp is activated before webrtcechoprobe, the webrtcechoprobe crashes in gst_webrtc_echo_probe_read() with SIGFPE because of self->info.bpf being 0 (i.e. the audio format has not been set yet). The attached patch checks for a valid audio format and aborts early if this is not the case.
Review of attachment 348866 [details] [review]: That's seems correct, I forgot that case.
Please add to 1.10 branch too.
commit da44fea1d170160efacaf0b87042d4228ef90c03 Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Mon Mar 27 18:14:54 2017 +0300 webrtcechoprobe: return from _read() early if the probe is not configured yet https://bugzilla.gnome.org/show_bug.cgi?id=780642 commit 9dc64fbbaf47004070222181930d27ae0ff2ea29 Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Mon Mar 27 18:14:54 2017 +0300 webrtcechoprobe: return from _read() early if the probe is not configured yet https://bugzilla.gnome.org/show_bug.cgi?id=780642