GNOME Bugzilla – Bug 780478
v4l2object: add videometa if there is padding to the right and bottom
Last modified: 2017-03-24 18:00:53 UTC
v4l2object only adds videometa if necessary. It performs several checks to see if the videometa is actually needed. One of these checks sees if there is padding present. However, at the moment, it only looks at the top and left borders for padding - not at the right and bottom ones. The result is that pipelines like this one produce incorrect results: videotestsrc ! "video/x-raw, format=I420, width=480, height=270" ! x264enc ! v4l2videoNdec Since 270 is not a multiple of 16, x264 will add 2 padding rows to the bottom. And since v4l2object ignores these padding rows, it will not add a videometa, even though it is actually needed to inform downstream about the correct plane offsets with the padding included.
Created attachment 348606 [details] [review] Patch for extending the padding check
Also in 1.10 commit cebf961dd53e38fb01420c6b20d6804ea69920cf Author: Carlos Rafael Giani <dv@pseudoterminal.org> Date: Thu Mar 23 22:13:05 2017 +0100 v4l2object: Also add videometa if there is padding to the right and bottom https://bugzilla.gnome.org/show_bug.cgi?id=780478