GNOME Bugzilla – Bug 780372
"Compact" mode for route lables in transit results aren't actually used
Last modified: 2017-04-03 21:36:58 UTC
There is two special cases when drawing the icons for individual transit legs in the transit itinerary overview (that comes up as the result of a transit route search), when there's many legs (more than 5), they are using a contracted mode where only the "mode of transportation" icon is shown. The other case, with at least three legs the route label is supposed to be drawn in a more compact manner (using some heuristics such as showing the agency name if that is shorter than the route name). However, currently this doesn't work as intended. It has probably been lost, since one parameter is using the wrong variable.
Created attachment 348444 [details] Screenshot showing non-compacted route labels
Created attachment 348445 [details] [review] transitItineraryRow: Actually use compact route labels Use the compact mode for route labels properly when appropriate.
Created attachment 348446 [details] Screenshot after patch
Review of attachment 348445 [details] [review]: LGTM!
Attachment 348445 [details] pushed as a121e92 - transitItineraryRow: Actually use compact route labels
(In reply to Marcus Lundblad from comment #5) > Attachment 348445 [details] pushed as a121e92 - transitItineraryRow: > Actually use compact route labels Thanks for the review! :)