GNOME Bugzilla – Bug 780367
decklinkvideosrc: Add no-signal property
Last modified: 2017-03-22 13:19:47 UTC
Created attachment 348432 [details] [review] [patch] decklinkvideosrc: Add no-signal property Expose the no_signal variable as property
Any particular reason to make it a property? I think there should be a status message instead. (Or does that exist already?)
Currently, a warning or info is posted when a signal is lost or connected. (With GST_ELEMENT_WARNING or GST_ELEMENT_INFO) But there is no way to query the current signal status if the message was missed for some reason. If someone wants to know the signal status at some point of time, I find a property much more convenient than installing a message handler.
Comment on attachment 348432 [details] [review] [patch] decklinkvideosrc: Add no-signal property The patch looks correct, but it seems better to call this property positive. "have-signal" or similar.
Created attachment 348481 [details] [review] [patch] decklinkvideosrc: Add no-signal property
> Currently, a warning or info is posted when a signal is lost or connected. > (With GST_ELEMENT_WARNING or GST_ELEMENT_INFO) I think this should be some other kind of message (status/progress message). > But there is no way to query the current signal status if the message was > missed for some reason. If someone wants to know the signal status at some > point of time, I find a property much more convenient than installing a > message handler. That is true. But this is all API for application developers. They know in advance whether they will be interested in this or not, and if they are, they will simply look for the messages and track state this way. It's not like the code suddenly changes its mind after running for a while :)
commit 7ee593e493b8d5a9b6ad70a62846a3610c3c2783 Author: Georg Lippitsch <georg.lippitsch@gmx.at> Date: Tue Mar 21 18:16:52 2017 +0100 decklinkvideosrc: Add read-only "signal" property https://bugzilla.gnome.org/show_bug.cgi?id=780367