After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780351 - thumbnailer: Don't copy remote files before thumbnailing
thumbnailer: Don't copy remote files before thumbnailing
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-21 13:08 UTC by Bastien Nocera
Modified: 2017-03-27 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
thumbnailer: Don't copy remote files before thumbnailing (1.34 KB, patch)
2017-03-21 13:08 UTC, Bastien Nocera
committed Details | Review
thumbnailer: Also handle trash and recent files as local files (1.61 KB, patch)
2017-03-21 13:08 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2017-03-21 13:08:24 UTC
.
Comment 1 Bastien Nocera 2017-03-21 13:08:28 UTC
Created attachment 348408 [details] [review]
thumbnailer: Don't copy remote files before thumbnailing

There's no need to copy the file locally when we can read it directly
through FUSE.
Comment 2 Bastien Nocera 2017-03-21 13:08:33 UTC
Created attachment 348409 [details] [review]
thumbnailer: Also handle trash and recent files as local files

By searching for the target.
Comment 3 Carlos Garcia Campos 2017-03-26 09:21:29 UTC
Comment on attachment 348408 [details] [review]
thumbnailer: Don't copy remote files before thumbnailing

Ok.
Comment 4 Carlos Garcia Campos 2017-03-26 09:23:24 UTC
Push to both branches, thanks!
Comment 5 Bastien Nocera 2017-03-26 15:47:15 UTC
(In reply to Carlos Garcia Campos from comment #4)
> Push to both branches, thanks!

I don't see it as pushed here on master. I guess you can also mark it as FIXED once you've pushed it.
Comment 6 Carlos Garcia Campos 2017-03-27 09:34:40 UTC
(In reply to Bastien Nocera from comment #5)
> (In reply to Carlos Garcia Campos from comment #4)
> > Push to both branches, thanks!
> 
> I don't see it as pushed here on master. I guess you can also mark it as
> FIXED once you've pushed it.

Nope I marked patches as accepted-commit_now, so you can push them yourself, and then I said push, not pushed, asking you to push the patches to both branches :-)
Comment 7 Bastien Nocera 2017-03-27 12:33:56 UTC
Attachment 348408 [details] pushed as f6f9891 - thumbnailer: Don't copy remote files before thumbnailing
Attachment 348409 [details] pushed as f25a684 - thumbnailer: Also handle trash and recent files as local files