After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780320 - Double-clicking on a ROM should launch gnome-games
Double-clicking on a ROM should launch gnome-games
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-20 17:42 UTC by Bastien Nocera
Modified: 2017-05-05 11:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core: Add PluginRegisterIterator (2.77 KB, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
Replace old plugin register iteration (3.07 KB, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
tracker: Add MimeTypeTrackerQuery.is_uri_valid() (1.57 KB, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
Remove unused UriGameFactory.is_uri_valid() (2.70 KB, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
Rename GenericSyncGameUriAdapter into GenericGameUriAdapter (18.30 KB, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
mame: Yield on MameGameUriAdapter.game_for_uri() (1.07 KB, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
generic: Yield on GenericGameUriAdapter.game_for_uri() (1009 bytes, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
desktop: Add DesktopTrackerQuery.game_for_uri() (2.22 KB, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
playstation: Add PlayStationGameFactory.game_for_uri() (1.28 KB, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
generic: Add GenericUriGameFactory.game_for_uri() (1019 bytes, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
core: Add UriGameFactory.game_for_uri() (861 bytes, patch)
2017-04-13 14:26 UTC, Adrien Plazas
none Details | Review
tracker: Move TrackerError to its own file (1.52 KB, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
tracker: Add MimeTypeTrackerQuery.game_for_uri() (1.47 KB, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
tracker: Add TrackerQuery.game_for_uri() (988 bytes, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
tracker: Add TrackerGameSource.game_for_uri() (1.15 KB, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
steam: Add SteamGameSource.game_for_uri() (3.08 KB, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
libretro: Add LibretroGameSource.game_for_uri() (2.50 KB, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
dummy: Add DummyGameSource.game_for_uri() (998 bytes, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
core: Add GameSource.game_for_uri() (830 bytes, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
ui: Handle opening game URIs (2.10 KB, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
data: Declare handled MIME-types (1.55 KB, patch)
2017-04-13 14:27 UTC, Adrien Plazas
none Details | Review
generic: Add GenericUriGameFactory.query_game_for_uri() (1.12 KB, patch)
2017-05-05 10:57 UTC, Adrien Plazas
committed Details | Review
playstation: Add PlayStationGameFactory.query_game_for_uri() (1.05 KB, patch)
2017-05-05 10:58 UTC, Adrien Plazas
committed Details | Review
core: Add UriGameFactory.query_game_for_uri() (903 bytes, patch)
2017-05-05 10:58 UTC, Adrien Plazas
committed Details | Review
generic: Add GenericUriGameSource.query_game_for_uri() (1.32 KB, patch)
2017-05-05 10:58 UTC, Adrien Plazas
committed Details | Review
ui: Handle opening game URIs (3.52 KB, patch)
2017-05-05 10:58 UTC, Adrien Plazas
committed Details | Review
data: Declare handled MIME-types (1.57 KB, patch)
2017-05-05 10:58 UTC, Adrien Plazas
committed Details | Review

Description Bastien Nocera 2017-03-20 17:42:29 UTC
For all the supported game types supported by the "plugins". If it can be listed, it should be in the list. This is how Totem does it as well, and you could then offer to try and download extra libretro cores, if available.
Comment 1 Adrien Plazas 2017-04-13 14:26:05 UTC
Created attachment 349803 [details] [review]
core: Add PluginRegisterIterator

Allow to loop through the content of PluginRegister in a synchronous or
asynchronous way.
Comment 2 Adrien Plazas 2017-04-13 14:26:10 UTC
Created attachment 349804 [details] [review]
Replace old plugin register iteration

Drop PluginRegister.foreach_plugin_registrar() and replace it with
PluginRegisterIterator.

This will allow to use asynchronous calls while looping through the
plugin registrars.
Comment 3 Adrien Plazas 2017-04-13 14:26:15 UTC
Created attachment 349805 [details] [review]
tracker: Add MimeTypeTrackerQuery.is_uri_valid()

Add this method to check that the received URIs correspond to existing
files of the queried type.

This replaces the usage of the corresponding method from UriGameFactory
which has never really been used and will be removed in the next commit.
Comment 4 Adrien Plazas 2017-04-13 14:26:19 UTC
Created attachment 349806 [details] [review]
Remove unused UriGameFactory.is_uri_valid()
Comment 5 Adrien Plazas 2017-04-13 14:26:25 UTC
Created attachment 349807 [details] [review]
Rename GenericSyncGameUriAdapter into GenericGameUriAdapter

Because characters are expensive.
Comment 6 Adrien Plazas 2017-04-13 14:26:29 UTC
Created attachment 349808 [details] [review]
mame: Yield on MameGameUriAdapter.game_for_uri()

Yields before returning a new game. This is a safe default as the method
is async and hence is expected to yield at some point.
Comment 7 Adrien Plazas 2017-04-13 14:26:35 UTC
Created attachment 349809 [details] [review]
generic: Yield on GenericGameUriAdapter.game_for_uri()

Yields before making the game from the URI. This is a safe default as
the callback can't do it and the method is async and hence is expected
to yield at some point.
Comment 8 Adrien Plazas 2017-04-13 14:26:43 UTC
Created attachment 349810 [details] [review]
desktop: Add DesktopTrackerQuery.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 9 Adrien Plazas 2017-04-13 14:26:48 UTC
Created attachment 349811 [details] [review]
playstation: Add PlayStationGameFactory.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 10 Adrien Plazas 2017-04-13 14:26:52 UTC
Created attachment 349812 [details] [review]
generic: Add GenericUriGameFactory.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 11 Adrien Plazas 2017-04-13 14:26:58 UTC
Created attachment 349813 [details] [review]
core: Add UriGameFactory.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 12 Adrien Plazas 2017-04-13 14:27:03 UTC
Created attachment 349814 [details] [review]
tracker: Move TrackerError to its own file
Comment 13 Adrien Plazas 2017-04-13 14:27:08 UTC
Created attachment 349815 [details] [review]
tracker: Add MimeTypeTrackerQuery.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 14 Adrien Plazas 2017-04-13 14:27:13 UTC
Created attachment 349816 [details] [review]
tracker: Add TrackerQuery.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 15 Adrien Plazas 2017-04-13 14:27:17 UTC
Created attachment 349817 [details] [review]
tracker: Add TrackerGameSource.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 16 Adrien Plazas 2017-04-13 14:27:22 UTC
Created attachment 349818 [details] [review]
steam: Add SteamGameSource.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 17 Adrien Plazas 2017-04-13 14:27:28 UTC
Created attachment 349819 [details] [review]
libretro: Add LibretroGameSource.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 18 Adrien Plazas 2017-04-13 14:27:33 UTC
Created attachment 349820 [details] [review]
dummy: Add DummyGameSource.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 19 Adrien Plazas 2017-04-13 14:27:38 UTC
Created attachment 349821 [details] [review]
core: Add GameSource.game_for_uri()

This will be used in a subsequent commit to make a game from an URI.
Comment 20 Adrien Plazas 2017-04-13 14:27:44 UTC
Created attachment 349822 [details] [review]
ui: Handle opening game URIs

Allow to directly run games by passing their URI to the command line.
Comment 21 Adrien Plazas 2017-04-13 14:27:50 UTC
Created attachment 349823 [details] [review]
data: Declare handled MIME-types

Declare the handled MIME-types in the Desktop entry.

This allows to run games by double-clicking their files or by running
them via xdg-open.
Comment 22 Adrien Plazas 2017-05-05 10:57:59 UTC
Created attachment 351178 [details] [review]
generic: Add GenericUriGameFactory.query_game_for_uri()

This will be used to lookup is a game corresponding to some URI exists
in the URI game factory.
Comment 23 Adrien Plazas 2017-05-05 10:58:06 UTC
Created attachment 351179 [details] [review]
playstation: Add PlayStationGameFactory.query_game_for_uri()

This is needed to add UriGameFactory.query_game_for_uri().
Comment 24 Adrien Plazas 2017-05-05 10:58:13 UTC
Created attachment 351180 [details] [review]
core: Add UriGameFactory.query_game_for_uri()

This will allow to lookup for games in URI game factories.
Comment 25 Adrien Plazas 2017-05-05 10:58:20 UTC
Created attachment 351181 [details] [review]
generic: Add GenericUriGameSource.query_game_for_uri()

This will allow to lookup a game for a given URI in a generic URI game
source.

This will be used int he next commits to run games directly from URIs
passed via the command line.
Comment 26 Adrien Plazas 2017-05-05 10:58:26 UTC
Created attachment 351182 [details] [review]
ui: Handle opening game URIs

Allow to directly run games by passing their URI to the command line.
Comment 27 Adrien Plazas 2017-05-05 10:58:33 UTC
Created attachment 351183 [details] [review]
data: Declare handled MIME-types

Declare the handled MIME-types in the Desktop entry.

This allows to run games by double-clicking their files or by running
them via xdg-open.
Comment 28 Adrien Plazas 2017-05-05 11:18:30 UTC
Attachment 351178 [details] pushed as b0fc9e1 - generic: Add GenericUriGameFactory.query_game_for_uri()
Attachment 351179 [details] pushed as ef943bf - playstation: Add PlayStationGameFactory.query_game_for_uri()
Attachment 351180 [details] pushed as 73eca41 - core: Add UriGameFactory.query_game_for_uri()
Attachment 351181 [details] pushed as 58afbea - generic: Add GenericUriGameSource.query_game_for_uri()
Attachment 351182 [details] pushed as e70d544 - ui: Handle opening game URIs
Attachment 351183 [details] pushed as 9f9d578 - data: Declare handled MIME-types