After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780308 - [review] drop libgudev in favor of libudev [th/gudev-bgo780308]
[review] drop libgudev in favor of libudev [th/gudev-bgo780308]
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-20 14:45 UTC by Thomas Haller
Modified: 2017-03-22 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2017-03-20 14:45:49 UTC 
please review
Comment 1 Beniamino Galvani 2017-03-21 08:38:19 UTC 
> udev: drop libgudev in favor of libudev

+}
+
+
+/**
+ * nm_udev_client_new:

Extra empty line.


-       if (!ensure_udev_client (device))
-               return NULL;
+       ensure_udev_client (device);

nm_udev_client_new() can fail, I think here we should check if the
client is available, because it's asserted later.


> udev: add and use nm_udev_utils_property_decode() function

+const char *
+nm_udev_utils_property_decode (const char *uproperty, char **to_free)
+{
+       const char *p;
+       char *unescaped, *n;

shared/nm-utils/nm-udev-utils.c:81:10: error: ‘n’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
shared/nm-utils/nm-udev-utils.c:91:19: error: ‘unescaped’ may be used uninitialized in this function [-Werror=maybe-uninitialized]


The rest LGTM.
Comment 2 Thomas Haller 2017-03-21 10:44:56 UTC 
thanks. Fixed and repushed.
Comment 3 Beniamino Galvani 2017-03-21 22:27:58 UTC 
Looks good.