Created attachment 348191 [details] [review]
screenShield: Do not lock the screen when locked down

When using the 'disable-lock-screen' setting to lock down the screen
lock, the expectation is that users cannot lock the screen. However
as it turns out, all the setting currently does is hiding the lock
button in the system menu and making the lock settings in the privacy
panel inactive. That means that if the 'lock-screen-enabled' setting
isn't disabled and locked down as well, we will just continue to
lock the screen on inactivity - not to mention the keyboard shortcut
that isn't subject to that setting anyway.

Instead of expecting administrators to hunt down every possible way
of locking the screen and disabling it individually, we can easily
handle all cases by refusing to lock the screen when disabled by the
lockdown settings.

Created attachment 348192 [details] [review]
screenShield: Do not take an inhibitor when disabled by lockdown

Just as with the normal lock screen settings, we shouldn't request
a logind inhibitor when locking is disabled via lockdown settings.

Review of attachment 348191 [details] [review]:

looks obviously fine

wonder why it wasn't like this already...

Review of attachment 348192 [details] [review]:

lgtm

Attachment 348191 [details] pushed as 199bc85 - screenShield: Do not lock the screen when locked down
Attachment 348192 [details] pushed as a786f0b - screenShield: Do not take an inhibitor when disabled by lockdown