After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780121 - Add a flatpak manifest
Add a flatpak manifest
Status: RESOLVED FIXED
Product: gnome-nibbles
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-nibbles-maint
gnome-nibbles-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-16 03:58 UTC by Florian Müllner
Modified: 2017-03-18 23:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
app: Make app ID consistent with data files (1.73 KB, patch)
2017-03-16 03:59 UTC, Florian Müllner
committed Details | Review
flatpak: Add manifest (2.81 KB, patch)
2017-03-16 03:59 UTC, Florian Müllner
none Details | Review
flatpak: Add manifest (2.83 KB, patch)
2017-03-17 09:07 UTC, Florian Müllner
committed Details | Review
flatpak: Add manifest (2.83 KB, patch)
2017-03-18 23:00 UTC, Iulian Radu
committed Details | Review
app: Make app ID consistent with data files (1.73 KB, patch)
2017-03-18 23:00 UTC, Iulian Radu
committed Details | Review

Description Florian Müllner 2017-03-16 03:58:33 UTC
See patches.
Comment 1 Florian Müllner 2017-03-16 03:59:02 UTC
Created attachment 348051 [details] [review]
app: Make app ID consistent with data files

The app ID used by .desktop and .appdata files is currently
inconsistent with the app ID claimed on D-Bus. This isn't a
problem if the application is installed through normal
distribution channels, however flatpak requires a single
consistent ID for all exported files. Some of this can
be tweaked when building a flatpak, but it's much easier
to just use the same ID from the get-go.
Comment 2 Florian Müllner 2017-03-16 03:59:10 UTC
Created attachment 348052 [details] [review]
flatpak: Add manifest

There are currently too few games on http://flatpak.org/apps.html,
let's change that!
Comment 3 Michael Catanzaro 2017-03-17 03:28:42 UTC
Review of attachment 348052 [details] [review]:

::: org.gnome.Nibbles.json
@@ +34,3 @@
+                {
+                    "type": "git",
+                    "url": "git://git.gnome.org/gnome-nibbles"

It should use https. The git:// protocol has no security; we surely shouldn't use it for automatic builds. (Yes, JHBuild should be fixed). Other than that, cool thanks!
Comment 4 Florian Müllner 2017-03-17 09:07:24 UTC
Created attachment 348154 [details] [review]
flatpak: Add manifest

Sure!
Comment 5 Iulian Radu 2017-03-18 23:00:24 UTC
The following fixes have been pushed:
8941079 flatpak: Add manifest
b8d3bba app: Make app ID consistent with data files
Comment 6 Iulian Radu 2017-03-18 23:00:29 UTC
Created attachment 348237 [details] [review]
flatpak: Add manifest

There are currently too few games on http://flatpak.org/apps.html,
let's change that!
Comment 7 Iulian Radu 2017-03-18 23:00:34 UTC
Created attachment 348238 [details] [review]
app: Make app ID consistent with data files

The app ID used by .desktop and .appdata files is currently
inconsistent with the app ID claimed on D-Bus. This isn't a
problem if the application is installed through normal
distribution channels, however flatpak requires a single
consistent ID for all exported files. Some of this can
be tweaked when building a flatpak, but it's much easier
to just use the same ID from the get-go.