After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780054 - network: Close Wifi selection dialog when appropriate
network: Close Wifi selection dialog when appropriate
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 780662 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-03-14 19:35 UTC by Florian Müllner
Modified: 2017-03-28 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Close Wifi selection dialog when appropriate (1.37 KB, patch)
2017-03-14 19:35 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-03-14 19:35:24 UTC 
See patch.
Comment 1 Florian Müllner 2017-03-14 19:35:29 UTC 
Created attachment 347941 [details] [review]
network: Close Wifi selection dialog when appropriate

Currently when the wifi selection dialog is open when the screen lock is
activated, the dialog remains visible above the shield. This is clearly
broken, so close the dialog automatically on session mode changes if the
mode doesn't allow settings (as changing the access point is arguably a
user setting).
Comment 2 Rui Matos 2017-03-15 12:25:02 UTC 
Review of attachment 347941 [details] [review]:

obviously fine.

I wonder if there is any case where it makes sense to show shell modal dialogs when not in 'user' session mode.
Comment 3 Florian Müllner 2017-03-15 13:51:15 UTC 
(In reply to Rui Matos from comment #2)
> I wonder if there is any case where it makes sense to show shell modal
> dialogs when not in 'user' session mode.

There are at least the restart/power-off dialog on the login screen, and polkit dialogs[0]

[0] http://git.gnome.org/browse/gnome-shell/commit?id=0725a7d836
Comment 4 Florian Müllner 2017-03-20 18:14:02 UTC 
Attachment 347941 [details] pushed as f97a352 - network: Close Wifi selection dialog when appropriate
Comment 5 Florian Müllner 2017-03-28 18:49:39 UTC 
*** Bug 780662 has been marked as a duplicate of this bug. ***