GNOME Bugzilla – Bug 779878
Make telepathy integration optional
Last modified: 2017-03-13 16:22:03 UTC
After bug 771721 removed our build time dependency, it's relatively easy to isolate the remaining usage and just disable chat integration when telepathy isn't available at runtime. (There are some ugly bits in the patch, but I preferred keeping the handling in the telepathy component itself rather than making the components manager catch import errors and risk missing errors in non-optional components)
Created attachment 347671 [details] [review] lookingGlass: Don't include telepathy import by default It's hardly a common include nowadays, and removing it keeps all telepathy usage contained in the telepathyClient component.
Created attachment 347672 [details] [review] telepathyClient: Gracefully handle missing telepathy deps Telepathy's role has been diminishing continuously over the last couple of years, so while chat integration is a nice feature for those who use it, it is hard to justify keeping it as a hard dependency. To address this, split out the component from the client so we can handle missing typelibs gracefully by not providing any chat integration.
Review of attachment 347671 [details] [review]: ++
Review of attachment 347672 [details] [review]: the ?: usage surprised me for a minute there but I think it's ok
Attachment 347671 [details] pushed as 9a38011 - lookingGlass: Don't include telepathy import by default Attachment 347672 [details] pushed as b4df747 - telepathyClient: Gracefully handle missing telepathy deps
*** Bug 773438 has been marked as a duplicate of this bug. ***