After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779652 - non failable dbus methods trigger client-side errors
non failable dbus methods trigger client-side errors
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: D-Bus
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
: 643787 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-03-06 13:36 UTC by Carlos Garnacho
Modified: 2018-02-12 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Extend dbus-arguments test to include non-"failable" dbus methods (1.12 KB, patch)
2017-03-06 13:38 UTC, Carlos Garnacho 		committed Details | Review
codegen: Check there is a return error location before using it (4.61 KB, patch)
2017-03-06 13:38 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2017-03-06 13:36:36 UTC 
Because there is no given GError** argument, generated code may wrongly use an "error" variable that doesn't really exist. Adding patches to test/fix this.
Comment 1 Carlos Garnacho 2017-03-06 13:38:03 UTC 
Created attachment 347312 [details] [review]
tests: Extend dbus-arguments test to include non-"failable" dbus methods

Those break in C generated code when using a GError** variable that is
not there.
Comment 2 Carlos Garnacho 2017-03-06 13:38:09 UTC 
Created attachment 347313 [details] [review]
codegen: Check there is a return error location before using it

Fixes client-side dbus generation on methods that don't throw any error.
Comment 3 Rico Tzschichholz 2017-03-06 14:38:14 UTC 
Attachment 347313 [details] pushed as 379a7b1 - codegen: Check there is a return error location before using it
Comment 4 Rico Tzschichholz 2018-02-12 09:11:43 UTC 
*** Bug 643787 has been marked as a duplicate of this bug. ***