GNOME Bugzilla – Bug 779570
popover: Add more padding between checkbox and label
Last modified: 2017-05-17 16:20:25 UTC
Please add more padding between a checkbox and its label in a GtkPopover. See this screenshot of devhelp 3.23.91 which shows the cramped "Side Panel" menu item. https://bug779385.bugzilla-attachments.gnome.org/attachment.cgi?id=346980 This has been worked around in totem and eog but the devhelp maintainer says that he'd rather this be fixed in gtk+ because 1) every app shouldn't need to do this if they have a checkbox in their popover 2) manually setting a size request for the popover does not work very well for translations References: https://git.gnome.org/browse/totem/commit/?id=ed7309ea https://git.gnome.org/browse/eog/commit/?id=a4cfef17 https://bugzilla.gnome.org/779385
Checks (or radios) in adwaita have a 4px margin per side, which sounds okish to me, I can probably increase the spacing, but the issue I see there is a that the check should be right aligned.
Looks like the check is *already* right aligned in the screenshot, hence my fault, patch coming.
I pushed a fix to both master and gtk-3-22. I increased the spacing from 4px to 12px and set to 0 the right side check margin, this is probably something that should be done generally, but I don't know what I may break, hence I just special cased the popover as in this particular issue.
Created attachment 351001 [details] "after" screenshot
*** Bug 779385 has been marked as a duplicate of this bug. ***