After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779431 - Use g_content_type for reporting type support
Use g_content_type for reporting type support
Status: RESOLVED FIXED
Product: gnome-autoar
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Autoar maintainer(s)
GNOME Autoar maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-01 18:19 UTC by Carlos Soriano
Modified: 2017-03-03 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
autoar-mime-types: update supported mime types with shared-mime-info (1.55 KB, patch)
2017-03-01 18:19 UTC, Carlos Soriano 		committed Details | Review
mime-types: use g_content_type_is_a for mime support (2.10 KB, patch)
2017-03-01 18:19 UTC, Carlos Soriano 		committed Details | Review

Description Carlos Soriano 2017-03-01 18:19:42 UTC 
.
Comment 1 Carlos Soriano 2017-03-01 18:19:47 UTC 
Created attachment 346987 [details] [review]
autoar-mime-types: update supported mime types with shared-mime-info

We were using a mix of supported mime types, that some weren't super
types in shared-mime-info.

Use only super types and in an upcoming patch we will use the right
function to check whether a mime type is a super type of another.
Comment 2 Carlos Soriano 2017-03-01 18:19:52 UTC 
Created attachment 346988 [details] [review]
mime-types: use g_content_type_is_a for mime support

We were using a plain text matching, which is less than ideal and prone
to error.

One clear practical issue is that rar was reported as not supported,
since the supertype is vnd.rar, not any alias like x-rar, etc.

This patch fix autoar to make sure we check for the supertypes for
reporting whether the types are supported or not.
Comment 3 Carlos Soriano 2017-03-01 18:20:13 UTC 
*** Bug 772765 has been marked as a duplicate of this bug. ***
Comment 4 Carlos Soriano 2017-03-03 09:57:18 UTC 
Hey I'm commiting for now since file-roller commited the counterpart.
If someone has some objection/review, please feel free to say.

Attachment 346987 [details] pushed as 4cda32a - autoar-mime-types: update supported mime types with shared-mime-info
Attachment 346988 [details] pushed as d7e45a2 - mime-types: use g_content_type_is_a for mime support