After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779383 - quartz: Let CSD windows be fullscreen
quartz: Let CSD windows be fullscreen
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-02-28 22:08 UTC by Matthias Clasen
Modified: 2017-03-02 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
quartz: Let CSD windows be fullscreen (1.07 KB, patch)
2017-02-28 22:09 UTC, Matthias Clasen
committed Details | Review
Convince OS X to fully fullscreen windows (924 bytes, patch)
2017-02-28 23:47 UTC, Matthias Clasen
none Details | Review
Convince OS X to fully fullscreen windows (1.52 KB, patch)
2017-03-02 03:50 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2017-02-28 22:08:52 UTC
I've found that I need this patch to make it possible for
windows with headerbar to be made fullscreen on OS X.
Comment 1 Matthias Clasen 2017-02-28 22:09:02 UTC
Created attachment 346938 [details] [review]
quartz: Let CSD windows be fullscreen
Comment 2 Emmanuele Bassi (:ebassi) 2017-02-28 22:16:03 UTC
Review of attachment 346938 [details] [review]:

Seems to be okay, according to the developer documentation.

The symbol is available since macOS 10.7, which is definitely what we require these days.
Comment 3 Matthias Clasen 2017-02-28 23:47:56 UTC
Created attachment 346942 [details] [review]
Convince OS X to fully fullscreen windows

We typically want to have the full screen given to
the content, not the aspect-ratio preserving behavior
that newer OS X has.
Comment 4 Matthias Clasen 2017-03-01 11:35:00 UTC
Something is not quite right yet. With the second patch, unfullscreening does not restore the previous window size.
Comment 5 Emmanuele Bassi (:ebassi) 2017-03-01 11:53:20 UTC
Maybe we need to store the previous size ourselves, and restore it by using windowDidExitFullscreen?

See: https://developer.apple.com/library/content/documentation/General/Conceptual/MOSXAppProgrammingGuide/FullScreenApp/FullScreenApp.html
Comment 6 Matthias Clasen 2017-03-01 16:48:24 UTC
Comment on attachment 346938 [details] [review]
quartz: Let CSD windows be fullscreen

Attachment 346938 [details] pushed as 169e2d8 - quartz: Let CSD windows be fullscreen
Comment 7 Matthias Clasen 2017-03-02 03:50:12 UTC
Created attachment 347018 [details] [review]
Convince OS X to fully fullscreen windows

We typically want to have the full screen given to
the content, not the aspect-ratio preserving behavior
that newer OS X has.
Comment 8 Matthias Clasen 2017-03-02 03:51:47 UTC
This one works and restores the unfullscreened window size
Comment 9 Emmanuele Bassi (:ebassi) 2017-03-02 11:19:49 UTC
Review of attachment 347018 [details] [review]:

Looking good.
Comment 10 Matthias Clasen 2017-03-02 13:12:01 UTC
Attachment 347018 [details] pushed as 015ff46 - Convince OS X to fully fullscreen windows