Created attachment 346836 [details] [review]
desktop-canvas-view: fix crash on refresh

Refreshing the desktop makes nautilus-desktop crash

The cause of this crash is that the desktop canvas view is a floating
reference. To fix this, remove the floating reference

Review of attachment 346836 [details] [review]:

excellent, thanks!!

Can you explain that we ref sink the reference in all the other views because we want to manage them as data structures too and that in commit https://git.gnome.org/browse/nautilus/commit/?id=5c414bfcd181375c5defd7f13b00d422f5384b9e we moved to a different way of creating the desktop view and we forgot to sink the floating ref in the port?

Created attachment 346924 [details] [review]
desktop-canvas-view: fix crash on refresh

Refreshing the desktop makes nautilus-desktop crash.

The cause of this crash is that the desktop canvas view is a floating
reference. In commit 5c414bfcd181375c5defd7f13b00d422f5384b9e the creation
of the desktop view was changed and it was forgotten to sink the floating
ref.

To fix this, remove the floating reference. The reason why the ref sink
is needed here, as well as in all the other views, is because the views
are also managed as data structures.

Review of attachment 346924 [details] [review]:

+1

(I'll commit myself to have it in the release)

Attachment 346924 [details] pushed as 0cab9f0 - desktop-canvas-view: fix crash on refresh