After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779245 - qtdemux: make sure taglist is writable before adding tags
qtdemux: make sure taglist is writable before adding tags
Status: RESOLVED DUPLICATE of bug 766177
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.10.x
Other Mac OS
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-26 07:26 UTC by Changbok
Modified: 2017-04-19 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: make sure taglist is writable before adding tags (1.10 KB, patch)
2017-02-26 07:26 UTC, Changbok 		none Details | Review

Description Changbok 2017-02-26 07:26:35 UTC 
Created attachment 346736 [details] [review]
qtdemux: make sure taglist is writable before adding tags

Fix assertion about gst_tag_list_add() in gst_qtdemux_guess_bitrate) function
Comment 1 Tim-Philipp Müller 2017-04-19 12:34:07 UTC 
Thanks for the patch, sorry it took so long until someone had a look at it.

This issue seems to have been fixed already as part of

commit 642331fd7f5b6236049fbd3b56f2f7f8a71ba174
Author: David Warman <dwarman@manglebit.org>
Date:   Fri Jan 13 12:27:40 2017 +0000

    qtdemux: avoid XMP tag parsing fatal error.
    
    qtdemux_handle_xmp_taglist() requires a writable taglist,
    but qtdemux->tag_list can become non-writable, specifically
    after sending global tags (qtdemux.c:958), which adds a
    second reference.  Ensure the list is made writable before
    calling (make_writable will copy the list if necessary).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766177

modulo the set_scope(GLOBAL) bit which I don't think is correct in this case.

*** This bug has been marked as a duplicate of bug 766177 ***