After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779120 - vaapiencoder: miscellaneous potential bug
vaapiencoder: miscellaneous potential bug
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-23 06:10 UTC by Hyunjun Ko
Modified: 2017-02-28 17:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH 1/2] libs: encoder: set rate control info only when query succeed (1.33 KB, patch)
2017-02-23 06:22 UTC, Hyunjun Ko 		committed Details | Review
[PATCH 2/2] libs: encoder: ensure profile when context initialization (1.03 KB, patch)
2017-02-23 06:23 UTC, Hyunjun Ko 		committed Details | Review

Description Hyunjun Ko 2017-02-23 06:10:26 UTC 
I found something miscellaneous during my work.
These don't affect current behaviour, but I guess it might cause a problem in the future.
Comment 1 Hyunjun Ko 2017-02-23 06:22:24 UTC 
Created attachment 346531 [details] [review]
[PATCH 1/2] libs: encoder: set rate control info only when query  succeed

Currently, it set rate control information even when query fails.
In addition, it doesn't update any more since the flag
got_rate_control_mask is set to TRUE.
Comment 2 Hyunjun Ko 2017-02-23 06:23:14 UTC 
Created attachment 346532 [details] [review]
[PATCH 2/2] libs: encoder: ensure profile when context initialization

We can't be sure that encoder's profile is assgined already or not 
at context initialization.
Comment 3 Víctor Manuel Jáquez Leal 2017-02-28 14:05:18 UTC 
Review of attachment 346531 [details] [review]:

lgtm
Comment 4 Víctor Manuel Jáquez Leal 2017-02-28 14:05:28 UTC 
Review of attachment 346532 [details] [review]:

lgtm
Comment 5 Víctor Manuel Jáquez Leal 2017-02-28 17:38:10 UTC 
commit 6468bf2ddf0463f5ec24a945ac4fad182fecac6f
Author: Hyunjun Ko <zzoon@igalia.com>

    libs: encoder: ensure profile when context initialization

commit 04a844ced08930e6f758b946f9396f573144992b
Author: Hyunjun Ko <zzoon@igalia.com>

    libs: encoder: set rate control info only when query succeed