GNOME Bugzilla – Bug 779082
window: use monitor information for max forced window size
Last modified: 2017-02-27 12:22:38 UTC
gdk_screen_get_{width,height} () have been deprecated in favor of per-monitor information. This commit replaces the deprecated API use.
Created attachment 346466 [details] [review] window: use monitor information for max forced window size
Review of attachment 346466 [details] [review]: LGTM
Created attachment 346489 [details] [review] window: use monitor information for max forced window size gdk_screen_get_{width,height} () have been deprecated in favor of per-monitor information. This commit replaces the deprecated API use.
This one is more correct, perhaps. I fetch the display from the screen I get from the widget, instead of using the default display.
Created attachment 346530 [details] [review] window: use monitor information for max forced window size gdk_screen_get_{width,height} () have been deprecated in favor of per-monitor information. This commit replaces the deprecated API use.
Review of attachment 346530 [details] [review]: As said on IRC, it's fine if we remove this code since we don't support less than the default 800x550 we have right now.
Created attachment 346620 [details] [review] window: remove max forced window size calculation Currently, the default size for window is calculated by taking the minimum value between the screen size and the hardcoded default. As the smallest recommended screen size for GNOME today is 1024x600 and the code has been added in 2000, it is likely no longer relevant. This commit simply makes the code use the hardcoded values within the recommended range as the default window size.
Review of attachment 346620 [details] [review]: yepi yepi
Attachment 346620 [details] pushed as de521dd - window: remove max forced window size calculation