GNOME Bugzilla – Bug 778832
Fix build failure on Continuous
Last modified: 2017-02-19 19:14:25 UTC
Continuous builds vte in a separate build directory. We caught this issue because Continuous disables the Vala bindings explicitly, which allows us to build VTE outside of the source directory.
Created attachment 346074 [details] [review] gir: Look in the right path for vtetypebuiltins.cc The vtetypebuiltins.cc file is generated, so it can only be found in the build directory, not in the source directory. This fixes non-srcdir builds like GNOME Continuous.
Review of attachment 346074 [details] [review]: This is a build failure that is affecting the whole GNOME project As part of the release team I'm ok on merging this; chpe feel free to contact us if you prefer another solution for this problem
Attachment 346074 [details] pushed as 9ca6db2 - gir: Look in the right path for vtetypebuiltins.cc
(In reply to Javier Jardón (IRC: jjardon) from comment #2) > This is a build failure that is affecting the whole GNOME project > As part of the release team I'm ok on merging this; chpe feel > free to contact us if you prefer another solution for this problem The patch is fine. Simple build fixes like this are always ok to commit. (A bit puzzled though why something from a 6 day old commit now suddently causes a problem?)
The builder has beeb out of commission since December and until this weekend, so we caught issues like these really late. Sorry about that.