After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778639 - Build SpiderMonkey 38 in gnome-continuous
Build SpiderMonkey 38 in gnome-continuous
Status: RESOLVED FIXED
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Philip Chimento
GNOME Continuous maintainer(s)
Depends on: 777962
Blocks:
 
 
Reported: 2017-02-15 00:29 UTC by Philip Chimento
Modified: 2017-02-15 23:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
manifest: Add mozjs38 (33.32 KB, patch)
2017-02-15 00:29 UTC, Philip Chimento 		committed Details | Review
Revert "manifest: tag gjs" (853 bytes, patch)
2017-02-15 00:29 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2017-02-15 00:29:28 UTC 
GJS will require SpiderMonkey 38 in GNOME 3.24. Here is a patch adding it to the gnome-continuous manifest.

I would appreciate some help - there is no guide or documentation for the ostbuild manifest format. Is there any way that I can test this without building the whole of gnome-continuous?
Comment 1 Philip Chimento 2017-02-15 00:29:52 UTC 
Created attachment 345766 [details] [review]
manifest: Add mozjs38

Required by GJS in GNOME 3.24.
Comment 2 Philip Chimento 2017-02-15 00:29:55 UTC 
Created attachment 345767 [details] [review]
Revert "manifest: tag gjs"

This reverts commit 551b9fee66682e6c5f741093e8fd375c7243703b.
We now have mozjs38 as of the previous commit.
Comment 3 Emmanuele Bassi (:ebassi) 2017-02-15 00:35:26 UTC 
Review of attachment 345766 [details] [review]:

I assume these are the same patches we apply in jhbuild.
Comment 4 Emmanuele Bassi (:ebassi) 2017-02-15 00:35:49 UTC 
Review of attachment 345767 [details] [review]:

Okay.
Comment 5 Emmanuele Bassi (:ebassi) 2017-02-15 00:37:17 UTC 
(In reply to Philip Chimento from comment #0)

> I would appreciate some help - there is no guide or documentation for the
> ostbuild manifest format. Is there any way that I can test this without
> building the whole of gnome-continuous?

Not really; what we do is, generally: push the changes and look at the results on https://build.gnome.org or, better, get notifications from the build bot in the #testable IRC channel on irc.gnome.org.
Comment 6 Philip Chimento 2017-02-15 02:56:40 UTC 
(In reply to Emmanuele Bassi (:ebassi) from comment #3)
> Review of attachment 345766 [details] [review] [review]:
> 
> I assume these are the same patches we apply in jhbuild.

Yes, minus the install-name one (only relevant for macOS) and plus the buildapi one (not needed in jhbuild because we have the source-subdir attribute.)

For that matter, this may not work because the mozjs-38.2.1 tarball unpacks into a mozjs-38.0.0 directory, which we fix with the checkoutdir attribute in jhbuild. Is there an equivalent in ostbuild?
Comment 7 Javier Jardón (IRC: jjardon) 2017-02-15 23:55:25 UTC 
Review of attachment 345766 [details] [review]:

commit 0140e896b32f52edca2f434501b52434244e8fca
Comment 8 Javier Jardón (IRC: jjardon) 2017-02-15 23:55:49 UTC 
Review of attachment 345767 [details] [review]:

commit 56210376148ed49e5a741bae62deb0b5cce2fa68
Comment 9 Javier Jardón (IRC: jjardon) 2017-02-15 23:56:24 UTC 
Some more patches were needed to make this work, thanks Philip for the help!