GNOME Bugzilla – Bug 778457
Odd layout in add user dialog
Last modified: 2017-03-22 14:22:07 UTC
Created attachment 345465 [details] screenshot and layout guidance There is some unpleasant layout in the add user dialog: • There isn't enough space above the controls - it doesn't match the spacing on the sides. • The content isn't horizontally centered - it is too far to the right. • Many of the controls are packed too closely - they need more vertical space. The overall effect is that the dialog feels unbalanced and constrained. See the attachment for a screenshot, which has been modified to show how it could be improved.
Created attachment 345564 [details] [review] user-accounts: Align the elements of "Add User" dialog
Created attachment 345565 [details] [review] user-accounts: Align enterprise login page in "Add User" dialog
Review of attachment 345564 [details] [review]: Looks much better to me, although it seems to me that Allan used a slightly bigger left/right border, but I haven't measured it... it would be nice to attach also screenshot for designers :-)
Review of attachment 345565 [details] [review]: The enterprise dialog looks pretty odd. I am afraid it was broken by some initial redesign changes, which were pushed in the last cycle :-( I think you should fix it as per: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/users/add-enterprise-user-account.png Allan?
(In reply to Ondrej Holy from comment #4) > Review of attachment 345565 [details] [review] [review]: > > The enterprise dialog looks pretty odd. I am afraid it was broken by some > initial redesign changes, which were pushed in the last cycle :-( > > I think you should fix it as per: > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/ > system-settings/users/add-enterprise-user-account.png > > Allan? I was guiding myself on this one mockup here https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/users/future/add-user-wires.png
Created attachment 345637 [details] [review] user-accounts: Align the elements of "Add User" dialog
Review of attachment 345637 [details] [review]: (In reply to Ondrej Holy from comment #3) > Review of attachment 345564 [details] [review] [review]: > > Looks much better to me, although it seems to me that Allan used a slightly > bigger left/right border, but I haven't measured it... it would be nice to > attach also screenshot for designers :-) ::: panels/user-accounts/data/account-dialog.ui @@ +91,3 @@ <property name="column_spacing">6</property> + <property name="row_spacing">8</property> + <property name="border_width">30</property> yep, the border_width of the input containers was missing some pixels. I measured the proportions on gimp and it seems alright now.
Created attachment 345649 [details] screenshots of enterprise dialog (In reply to Felipe Borges from comment #5) > (In reply to Ondrej Holy from comment #4) > > Review of attachment 345565 [details] [review] [review] [review]: > > > > The enterprise dialog looks pretty odd. I am afraid it was broken by some > > initial redesign changes, which were pushed in the last cycle :-( > > > > I think you should fix it as per: > > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/ > > system-settings/users/add-enterprise-user-account.png > > > > Allan? > > I was guiding myself on this one mockup here > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/ > system-settings/users/future/add-user-wires.png See the attachment. The problem appears especially with font-scale, however, the margins are slightly different anyway. Can you please do something with it?
Review of attachment 345637 [details] [review]: Looks ok to me...
Comment on attachment 345637 [details] [review] user-accounts: Align the elements of "Add User" dialog Attachment 345637 [details] pushed as 51a184b - user-accounts: Align the elements of "Add User" dialog
Created attachment 345733 [details] [review] user-accounts: Align enterprise login page in "Add User" dialog
Review of attachment 345733 [details] [review]: I still see the same problems as with the obsoleted patch. I think that margin-right is missing somewhere (see with font scale bigger than 1). Also the "Enterprise Login" toggle should not be too close to dialog border, see mockup.
Created attachment 346231 [details] [review] user-accounts: Reduce max-width-chars for multiline labels The "max-width-chars" property was changed a bit with the introduction of width-for-height geometry management and the labels are wider currently than in mockup. Let's reduce its value a bit and add xalign for sure.
Created attachment 346232 [details] [review] user-accounts: Align "Enterprise login" toggle The "Enterprise login" toggle should have bigger border as per mockup. Let's increase it a bit.
Created attachment 346233 [details] [review] user-accounts: Add missing widgets in size group Some control widgets are missing in size group. Let's add them and also allow hexpand for them.
Created attachment 346234 [details] [review] user-accounts: Unify row spacing Commit 51a184b changed row spacing for local accounts, change that also for enterprise part.
Created attachment 346235 [details] [review] user-accounts: Fix widget alignment on add user dialog Widgets on local and enterprise pages of add user dialog don't have same width regardless of size groups. It is caused by different margins and borders of various widgets. Let's change them to be like in mockup.
Created attachment 346236 [details] fixed enterprise dialog screenshots I've tried to fix the problems with the enterprise page of the add user dialog and ended up with the all previous patches. It works nicely with font-scaling now and reflects more the mockup. See attached screenshot...
Review of attachment 346231 [details] [review]: sure.
Review of attachment 346232 [details] [review]: sure
Review of attachment 346233 [details] [review]: ok
Review of attachment 346234 [details] [review]: sure
Review of attachment 346235 [details] [review]: I'm afraid the margin in the top is bit more than the mockup. But other than that it's fine.
Comment on attachment 345733 [details] [review] user-accounts: Align enterprise login page in "Add User" dialog obsolete
(In reply to Felipe Borges from comment #23) > Review of attachment 346235 [details] [review] [review]: > > I'm afraid the margin in the top is bit more than the mockup. But other than > that it's fine. I think it is ok. It should be the same as it was introduced by your attachment 345637 [details] [review], which was suggested in Comment 0. So the original mockup is a bit outdated due to this...
(In reply to Ondrej Holy from comment #25) > (In reply to Felipe Borges from comment #23) > > Review of attachment 346235 [details] [review] [review] [review]: > > > > I'm afraid the margin in the top is bit more than the mockup. But other than > > that it's fine. > > I think it is ok. It should be the same as it was introduced by your > attachment 345637 [details] [review] [review], which was suggested in Comment 0. So > the original mockup is a bit outdated due to this... alright. no problem.
Review of attachment 346231 [details] [review]: The max-width-chars change is not probably needed. I am not sure why, but it looks ok without it on rawhide. Maybe I was testing it against some buggy version of GTK+. But xalign is needed...
Created attachment 348487 [details] [review] user-accounts: Align multiline labels So I've removed the max-width-char changes...
Created attachment 348488 [details] [review] user-accounts: Align "Enterprise login" toggle
Created attachment 348489 [details] [review] user-accounts: Add missing widgets in size group
Created attachment 348490 [details] [review] user-accounts: Unify row spacing
Created attachment 348491 [details] [review] user-accounts: Fix widget alignment on add user dialog So, I have finally removed margin_top in local-area. It was different than in enterprise part and it was really too much as per the attachment 345465 [details].
Attachment 348487 [details] pushed as 54c4dbb - user-accounts: Align multiline labels Attachment 348488 [details] pushed as 921ef1b - user-accounts: Align "Enterprise login" toggle Attachment 348489 [details] pushed as 932cdd3 - user-accounts: Add missing widgets in size group Attachment 348490 [details] pushed as a748d52 - user-accounts: Unify row spacing Attachment 348491 [details] pushed as c49d1cc - user-accounts: Fix widget alignment on add user dialog