After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778113 - display base of search when moving in search window
display base of search when moving in search window
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
3.22.x
Other Linux
: Normal minor
: 3.24
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-02 21:20 UTC by soloturn
Modified: 2017-03-22 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
files-view: display search base for file chooser (1.70 KB, patch)
2017-03-19 23:45 UTC, Alexandru Pandelea 		none Details | Review
files-view: display search base for file chooser (1.70 KB, patch)
2017-03-22 20:35 UTC, Alexandru Pandelea 		committed Details | Review

Description soloturn 2017-02-02 21:20:26 UTC 
1. search for something
2. on the result right click "move to"
3. a window opens "the folder contents could not be displayed, the specified location is not supported"

on 3 i would expect that the base of the search is displayed.
Comment 1 Alexandru Pandelea 2017-03-19 23:45:39 UTC 
Created attachment 348287 [details] [review]
files-view: display search base for file chooser

Currently when the move to/copy to file chooser dialog is launched
during search, the dialog shows an error as the location is invalid.

Change this so that the base of the search is displayed in the dialog
when this dialog is launched while searching.
Comment 2 Carlos Soriano 2017-03-22 16:12:30 UTC 
Review of attachment 348287 [details] [review]:

Excellent!!

Can you switch the if()? I kinda like to have the conditions as positive as possible if (nautilus_is_in_search) rather than if (!natilus_is_in_search).

Feel free to commit afterwards :)
Comment 3 Alexandru Pandelea 2017-03-22 20:35:16 UTC 
Created attachment 348530 [details] [review]
files-view: display search base for file chooser

Currently when the move to/copy to file chooser dialog is launched
during search, the dialog shows an error as the location is invalid.

Change this so that the base of the search is displayed in the dialog
when this dialog is launched while searching.
Comment 4 Alexandru Pandelea 2017-03-22 20:38:00 UTC 
Attachment 348530 [details] pushed as b57d592 - files-view: display search base for file chooser