After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778013 - rtpsession: relate received FIRs and PLIs to source
rtpsession: relate received FIRs and PLIs to source
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-01 08:07 UTC by Miguel París Díaz
Modified: 2017-02-03 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpsession: relate received FIRs and PLIs to source (7.77 KB, patch)
2017-02-01 08:07 UTC, Miguel París Díaz 		needs-work Details | Review
(master) rtpsession: relate received FIRs and PLIs to source (7.95 KB, patch)
2017-02-02 12:02 UTC, Miguel París Díaz 		committed Details | Review

Description Miguel París Díaz 2017-02-01 08:07:16 UTC 
Created attachment 344686 [details] [review]
rtpsession: relate received FIRs and PLIs to source

Relate received FIRs and PLIs to source in order to:
  - Avoid ignoring requests for different media sources.
  - Add SSRC field in the GstForceKeyUnit event.
Comment 1 Olivier Crête 2017-02-01 18:01:05 UTC 
Review of attachment 344686 [details] [review]:

Indeed, this was created when there was a single sending source per session, before the bundle support was added, good catch.

That said, your patch doesn't apply on git master, so please rebase it
Comment 2 Miguel París Díaz 2017-02-02 12:02:21 UTC 
Created attachment 344767 [details] [review]
(master) rtpsession: relate received FIRs and PLIs to source

@oliver,
you are right the parch was done over 1.8 branch.
I am uploading the patch rebased over master ;).
Comment 3 Olivier Crête 2017-02-02 17:17:44 UTC 
Merged

commit 3aa69ca0bb771cfadfe6d1a29ae49da2dc39d8a2
Author: Miguel París Díaz <mparisdiaz@gmail.com>
Date:   Thu Feb 2 12:55:25 2017 +0100

    rtpsession: relate received FIRs and PLIs to source
    
    This is needed in order to:
     - Avoid ignoring requests for different media sources.
     - Add SSRC field in the GstForceKeyUnit event.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=778013
Comment 4 Miguel París Díaz 2017-02-03 08:42:52 UTC 
Thanks @olivier ;)