After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777948 - ACTION_ARCHIVE_MESSSAGE, ACTION_TRASH_MESSSAGE, and ACTION_DELETE_MESSSAGE actually operate on conversations
ACTION_ARCHIVE_MESSSAGE, ACTION_TRASH_MESSSAGE, and ACTION_DELETE_MESSSAGE ac...
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: general
0.11.x
Other Linux
: Normal normal
: 0.12.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks: 726100
 
 
Reported: 2017-01-30 17:02 UTC by Alex Henrie
Modified: 2017-02-23 04:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Rename archive/trash/delete actions to clearly be for conversations (14.46 KB, patch)
2017-01-30 17:02 UTC, Alex Henrie 		reviewed Details | Review

Description Alex Henrie 2017-01-30 17:02:34 UTC 
Created attachment 344570 [details] [review]
[PATCH] Rename archive/trash/delete actions to clearly be for conversations

The constants ACTION_ARCHIVE_MESSSAGE, ACTION_TRASH_MESSSAGE, and ACTION_DELETE_MESSSAGE in geary-controller.vala are confusingly named. They sound like they operate on individual messages, but they actually operate on group messages, i.e. conversations. The variables should be renamed before adding archive, trash, and delete actions that operate on individual messages (bug 726100).

The attached patch resolves the problem by replacing "MESSAGE" with "CONVERSATION" in these and other associated variables.
Comment 1 Michael Gratton 2017-02-01 14:21:21 UTC 
Review of attachment 344570 [details] [review]:

Thanks for the patch Alex, it would be good to clean that up a bit.

It looks good to me, Niels will it cause anything you're working any pain if this was landed?
Comment 2 Niels De Graef 2017-02-10 12:31:06 UTC 
It's ok to land this for me :-)
Comment 3 Alex Henrie 2017-02-22 19:10:49 UTC 
Ping
Comment 4 Michael Gratton 2017-02-23 00:34:47 UTC 
Just pushed to this as commit f38f0d1. Thanks for the patch (and the reminder)!
Comment 5 Alex Henrie 2017-02-23 04:00:22 UTC 
Thank you!