After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777936 - HTTP authentication doesn't work when done asynchronously and flag SOUP_MESSAGE_DO_NOT_USE_AUTH_CACHE is used
HTTP authentication doesn't work when done asynchronously and flag SOUP_MESSA...
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.57.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
: 778061 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-01-30 13:08 UTC by Carlos Garcia Campos
Modified: 2017-02-22 08:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
auth: Fix async authentication when flag SOUP_MESSAGE_DO_NOT_USE_AUTH_CACHE is used (4.85 KB, patch)
2017-01-30 13:10 UTC, Carlos Garcia Campos
committed Details | Review

Description Carlos Garcia Campos 2017-01-30 13:08:48 UTC
We are calling soup_message_set_auth right after emitting the authenticate signal only if the auth was already authenticated. But it's possible for users to pause the message, do the authentication, and then unpause the message. This relyes on the cached credentials to work, but we don't use them when the flag SOUP_MESSAGE_DO_NOT_USE_AUTH_CACHE is set.
Comment 1 Carlos Garcia Campos 2017-01-30 13:10:02 UTC
Created attachment 344539 [details] [review]
auth: Fix async authentication when flag SOUP_MESSAGE_DO_NOT_USE_AUTH_CACHE is used
Comment 2 Michael Catanzaro 2017-02-07 15:57:53 UTC
*** Bug 778061 has been marked as a duplicate of this bug. ***
Comment 3 Dan Winship 2017-02-20 19:51:37 UTC
Comment on attachment 344539 [details] [review]
auth: Fix async authentication when flag SOUP_MESSAGE_DO_NOT_USE_AUTH_CACHE is used

looks right