After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777844 - "Set shortcut" should be "Set Shortcut..."
"Set shortcut" should be "Set Shortcut..."
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-27 16:11 UTC by Bastien Nocera
Modified: 2017-01-30 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shortcut-dialog: fix wrong string (1.47 KB, patch)
2017-01-28 20:27 UTC, Georges Basile Stavracas Neto 		needs-work Details | Review
keyboard: follow mockups for shortcut change button label (1.51 KB, patch)
2017-01-30 10:34 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Comment 1 Georges Basile Stavracas Neto 2017-01-28 20:27:47 UTC 
Created attachment 344467 [details] [review]
shortcut-dialog: fix wrong string

Per the mockups, this should be "Set Shortcut…". This only
fixes the translation string, and the interaction flow is
being fixed in the appropriate bugs.
Comment 2 Bastien Nocera 2017-01-30 09:36:58 UTC 
Review of attachment 344467 [details] [review]:

> shortcut-dialog: fix wrong string

This should be "keyboard: ". And "fix wrong string" is a really bad explanation of what you did. How about "Follow mockups for shortcut change button label"

> Per the mockups,

Link to the mockups.

> This only fixes the translation string

I don't understand this.
Comment 3 Georges Basile Stavracas Neto 2017-01-30 10:34:45 UTC 
Created attachment 344523 [details] [review]
keyboard: follow mockups for shortcut change button label

Per the mockups [1], this should be "Set Shortcut…".

[1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png
Comment 4 Bastien Nocera 2017-01-30 10:46:33 UTC 
Review of attachment 344523 [details] [review]:

Sure.
Comment 5 Georges Basile Stavracas Neto 2017-01-30 10:52:58 UTC 
Attachment 344523 [details] pushed as 8200fa8 - keyboard: follow mockups for shortcut change button label