After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777678 - [PATCH] add Ctrl+Q keyboard accelerator quit shortcut
[PATCH] add Ctrl+Q keyboard accelerator quit shortcut
Status: RESOLVED FIXED
Product: gnome-dictionary
Classification: Core
Component: general
3.20.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-dictionary-maint
gnome-dictionary-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-24 05:00 UTC by eldergabriel
Modified: 2017-02-21 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description eldergabriel 2017-01-24 05:00:08 UTC
Ctrl+Q currently does not close gnome-dictionary. This is inconsistent with expected keyboard binding behaviour in comparison to most, if not all other gnome desktop applications. Please accept and merge this (diff -u) patch in to gnome-dictionary:

--- gdict-app-menus.ui	2016-03-22 03:15:31.000000000 -0500
+++ gdict-app-menus.ui.ctrlq	2017-01-23 21:11:14.385757543 -0600
@@ -24,8 +24,9 @@
         <attribute name="action">app.about</attribute>
       </item>
       <item>
-        <attribute name="label" translatable="yes">Quit</attribute>
+        <attribute name="label" translatable="yes">_Quit</attribute>
         <attribute name="action">app.quit</attribute>
+	<attribute name="accel">&lt;Primary&gt;Q</attribute>
       </item>
     </section>
   </menu>

so as to better conform with the rest of the standard gnome desktop applications conventions (e.g. gedit, etc.). Perhaps a version bump --> 3.20.1 would be appropriate(?), though this may be unwarranted. Running on Fedora 25 Gnome v3.22.2, in case anyone is wondering.
Comment 1 Felipe Borges 2017-02-21 14:29:14 UTC
I took the liberty to push your patch directly. Thanks.

Pushed as a07bf18