GNOME Bugzilla – Bug 777347
hidpi is never allowed on external monitors > SMALLEST_4K_WIDTH
Last modified: 2017-06-07 12:09:02 UTC
Created attachment 343578 [details] [review] I guess the logic is reversed here looks like a reversed check to me
Created attachment 352178 [details] [review] monitor-manger: invert logic for 4k TV scaling For devices connected via HDMI (supposedly TVs) we want have a scale factor of 1 if we are *below* the smallest 4k resolution width (not equal or above) and do the scaling factor computation if we are above the limit. This check was apparently wrongly ported from gnome-settings-daemon. Based of a patch by Caolan McNamara <caolanm@redhat.com>.
The original code is the 2 functions here: https://git.gnome.org//browse/gnome-settings-daemon/tree/plugins/xsettings/gsd-xsettings-manager.c#n521 and: https://git.gnome.org//browse/gnome-settings-daemon/tree/plugins/xsettings/gsd-xsettings-manager.c#n596
Review of attachment 352178 [details] [review]: So the code in gsd reads as "If it is not larger than 4K on HDMI, skip resolution check" while the mutter code previously read "If it is larger than 4K on HDMI, skip resolution check" so this change, making it do the same as gsd did does indeed make a lot of sense.