After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777340 - Links in System tab of Recipes about page is barely readable in dark theme.
Links in System tab of Recipes about page is barely readable in dark theme.
Status: RESOLVED FIXED
Product: recipes
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Recipes maintainer(s)
Recipes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-16 16:00 UTC by Mohammed Sadiq
Modified: 2017-01-16 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
recipes about system tab (image) (63.76 KB, image/png)
2017-01-16 16:00 UTC, Mohammed Sadiq 		  Details
about: fix link color in Adwaita dark theme (3.98 KB, patch)
2017-01-16 16:44 UTC, Mohammed Sadiq 		none Details | Review
about: fix link color in Adwaita dark theme (3.96 KB, patch)
2017-01-16 16:46 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2017-01-16 16:00:09 UTC 
The links in System tab in about page of Recipes app is barely readable with Adwaita dark theme.

This can probably be a gtk+ bug, though I'm not sure. So filing against Recipes.

How to reproduce:
1. run recipes: GTK_THEME=Adwaita:dark recipes
2. Go to Application Menu -> About -> System
Comment 1 Mohammed Sadiq 2017-01-16 16:00:38 UTC 
Created attachment 343569 [details]
recipes about system tab (image)
Comment 2 Matthias Clasen 2017-01-16 16:13:04 UTC 
Yes. Currently, we hardcode "blue" as the color. The fix here is to copy a bit more code from gtkaboutdialog.c in gtk to find the link color from the theme.

Do you feel like investigating that ?
Comment 3 Mohammed Sadiq 2017-01-16 16:44:37 UTC 
Created attachment 343574 [details] [review]
about: fix link color in Adwaita dark theme

The link color was hardcoded to blue color.
This was creating contrast issues in dark theme.

To fix this, get the link color from context and use.
Comment 4 Mohammed Sadiq 2017-01-16 16:46:23 UTC 
Created attachment 343575 [details] [review]
about: fix link color in Adwaita dark theme
Comment 5 Matthias Clasen 2017-01-16 17:04:25 UTC 
Attachment 343575 [details] pushed as 0ce6b21 - about: fix link color in Adwaita dark theme