After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777335 - Workaround for searchbar 1px bug
Workaround for searchbar 1px bug
Status: RESOLVED WONTFIX
Product: devhelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-16 15:33 UTC by Trinh Anh Ngoc
Modified: 2017-03-02 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (23.24 KB, image/png)
2017-01-16 15:33 UTC, Trinh Anh Ngoc 		  Details
Wrap searchbar in a revealer (6.95 KB, patch)
2017-01-16 15:34 UTC, Trinh Anh Ngoc 		none Details | Review
Workaround (7.02 KB, patch)
2017-01-16 15:37 UTC, Trinh Anh Ngoc 		none Details | Review
Workaround: wrap searchbar in a revealer (7.02 KB, patch)
2017-01-16 15:37 UTC, Trinh Anh Ngoc 		none Details | Review
Workaround: wrap searchbar in a revealer (6.40 KB, patch)
2017-01-16 15:53 UTC, Trinh Anh Ngoc 		reviewed Details | Review

Description Trinh Anh Ngoc 2017-01-16 15:33:12 UTC 
Created attachment 343563 [details]
screenshot

Gtk+ bug: https://bugzilla.gnome.org/show_bug.cgi?id=724096

The bug causes redundant border on top of document view.
Comment 1 Trinh Anh Ngoc 2017-01-16 15:34:24 UTC 
Created attachment 343564 [details] [review]
Wrap searchbar in a revealer
Comment 2 Trinh Anh Ngoc 2017-01-16 15:37:02 UTC 
Created attachment 343565 [details] [review]
Workaround
Comment 3 Trinh Anh Ngoc 2017-01-16 15:37:57 UTC 
Created attachment 343566 [details] [review]
Workaround: wrap searchbar in a revealer
Comment 4 Frederic Peters 2017-01-16 15:44:46 UTC 
Thanks I'm not a fan of working around GTK+ bugs but I'll leave the door open for other reviewers.
Comment 5 Trinh Anh Ngoc 2017-01-16 15:53:09 UTC 
Created attachment 343568 [details] [review]
Workaround: wrap searchbar in a revealer

Fix indent
Comment 6 Sébastien Wilmet 2017-01-18 10:54:46 UTC 
Review of attachment 343568 [details] [review]:

I also don't like this patch. I prefer a simple and stupid code, to reduce complexity instead of increasing it, to target bug-free code.
Comment 7 Sébastien Wilmet 2017-03-02 15:12:31 UTC 
OK, so the consensus is to not add a workaround in Devhelp.