After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777236 - batch-rename-dialog: Make ``check_conflict_for_files`` private
batch-rename-dialog: Make ``check_conflict_for_files`` private
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-13 20:39 UTC by Adrian Zatreanu
Modified: 2017-01-13 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
batch-rename-dialog: Make ``check_conflict_for_files`` private (1.85 KB, patch)
2017-01-13 20:39 UTC, Adrian Zatreanu
committed Details | Review

Description Adrian Zatreanu 2017-01-13 20:39:16 UTC
This function is only used inside the class file,
so it should not be public.
Comment 1 Adrian Zatreanu 2017-01-13 20:39:20 UTC
Created attachment 343452 [details] [review]
batch-rename-dialog: Make ``check_conflict_for_files`` private
Comment 2 Razvan Chitu 2017-01-13 20:44:27 UTC
Review of attachment 343452 [details] [review]:

LGTM, thanks!
Comment 3 Razvan Chitu 2017-01-13 20:52:14 UTC
Attachment 343452 [details] pushed as 4484f67 - batch-rename-dialog: Make ``check_conflict_for_files`` private