After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776674 - Invalid property on ArtistAlbum view
Invalid property on ArtistAlbum view
Status: RESOLVED INVALID
Product: gnome-music
Classification: Applications
Component: general
3.23.x
Other Linux
: Normal critical
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-01 12:10 UTC by Alberto Fanjul
Modified: 2017-01-09 17:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove invalid property defined (769 bytes, patch)
2017-01-01 12:10 UTC, Alberto Fanjul 		none Details | Review

Description Alberto Fanjul 2017-01-01 12:10:01 UTC 
Created attachment 342692 [details] [review]
Remove invalid property defined

Clicking on an album from albums view breaks gnome-music with

    Traceback (most recent call last):

+ Trace 237027

  • File "/home/alberto/jhbuild/install/lib/python3.5/site-packages/gnomemusic/grilo.py", line 290 in _callback 
    callback(source, param, item, remaining, data)
  • File "/home/alberto/jhbuild/install/lib/python3.5/site-packages/gnomemusic/widgets/albumwidget.py", line 287 in add_item 
    disc = self._create_disc_box(disc_nr, discs[disc_nr])
  • File "/home/alberto/jhbuild/install/lib/python3.5/site-packages/gnomemusic/widgets/albumwidget.py", line 229 in _create_disc_box 
    disc_box = DiscBox(self._model)
  • File "/home/alberto/jhbuild/install/lib/python3.5/site-packages/gnomemusic/widgets/disclistboxwidget.py", line 165 in __init__ 
    builder.add_from_resource('/org/gnome/Music/ArtistAlbumWidget.ui')     GLib.Error: gtk-builder-error-quark: .:3:2196 Invalid property: DiscListBox.selection_mode (11)






Comment 1


Marinus Schraal





          2017-01-09 13:16:21 UTC
        



This looks like a mangled source tree to me. The ui file which defines DiscListBox doesn't have selection_mode as a property (anymore).






Comment 2


Alberto Fanjul





          2017-01-09 14:13:52 UTC
        



This is the last commit about that line on master:

https://git.gnome.org/browse/gnome-music/commit/?id=e7fe2b7cf2e65eb9692a0f1c9e4319aa852dc29a

exact line:
https://github.com/GNOME/gnome-music/commit/e7fe2b7cf2e65eb9692a0f1c9e4319aa852dc29a#diff-470a8f4d3585046dd874c5000f769623R82

where can I find that file without selection_mode?






Comment 4


Alberto Fanjul





          2017-01-09 14:24:02 UTC
        



But problem is on line 125.






Comment 5


Marinus Schraal





          2017-01-09 16:22:23 UTC
        



It isn't, it is referring to DiscListBox, not DiscSongsFlowBox.






Comment 6


Alberto Fanjul





          2017-01-09 17:09:29 UTC
        



I see it finally (from stack trace). Have to rebase before submit a patch