GNOME Bugzilla – Bug 776559
adaptivedemux: Snap seek to other period does not work
Last modified: 2018-11-03 14:02:37 UTC
Subclass's stream_seek() work correctly only if the target seek position is inside the period corresponding to the stream. Maybe, in case of snap seeking, the code for adjustment of target seek position should be moved to subclass, but it's done by adaptivedemux now.
Created attachment 342560 [details] [review] adaptivedemux: Remove code for adjusting snap seek position Remove code to let subclass handle snap seeking
If we remove it here, the subclasses should all implement it. Can you provide patches for that? Or can it maybe be implemented generically in the baseclass somehow?
Created attachment 347257 [details] [review] adaptivedemux: Remove code for adjusting snap seek position stream_seek() is possible if and only if the target seek position is inside of current period, in case of DASH. Also, previous implementation caused stream_seek() twice for a certain stream (one done by adaptivdemux and the other done by subclass). it's obviously redundant operation. To handle snap seek, this patch removes the previous code, and adaptivdemux will just handle GST_SEEK_TYPE_NONE case. Then, let subclass handle snap seeking including gst_segment_do_seek(). Additionally, some macros which are commonly used by subclasses are moved to header to remove duplication.
Created attachment 347258 [details] [review] dashdemux: Handle snap seek
Created attachment 347259 [details] [review] hlsdemux: Handle snap seek
Created attachment 347260 [details] [review] mssdemux: Handle snap seek
Created attachment 352636 [details] [review] [1/4] adaptivedemux: Remove code for adjusting snap seek position rebase patch
Created attachment 352637 [details] [review] [2/4] dashdemux: Handle snap seek
Created attachment 352638 [details] [review] [3/4] hlsdemux: Handle snap seek
Created attachment 352639 [details] [review] [4/4] mssdemux: Handle snap seek
Snap seek with multi-period dash stream still shows problem in gst1.12
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/502.