After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776199 - Use /proc/self/cmdline on Solaris as well in shell_global_reexec_self()
Use /proc/self/cmdline on Solaris as well in shell_global_reexec_self()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.20.x
Other Solaris
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-17 07:31 UTC by Alan Coopersmith
Modified: 2017-02-10 10:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch currently used in Solaris builds (753 bytes, patch)
2016-12-17 07:31 UTC, Alan Coopersmith 		none Details | Review
Patch with updated comment as requested (1.07 KB, patch)
2016-12-17 16:38 UTC, Alan Coopersmith 		committed Details | Review

Description Alan Coopersmith 2016-12-17 07:31:30 UTC 
Created attachment 342108 [details] [review]
Patch currently used in Solaris builds

Solaris 11.3.5 and later have a Linux-compatible implementation of
/proc/self/cmdline, so the code to use it can be enabled in gnome-shell
on Solaris - if built on an older OS, it simply fails to open the file
and returns without doing anything, just as the code did before enabling
this.
Comment 1 Florian Müllner 2016-12-17 10:49:16 UTC 
Review of attachment 342108 [details] [review]:

Please add the bug URL to the commit message (and ideally the explanation from comment #0 as well). Otherwise looks good to me.
Comment 2 Alan Coopersmith 2016-12-17 16:38:28 UTC 
Created attachment 342123 [details] [review]
Patch with updated comment as requested

Thanks for the review - I've updated the git commit comments as suggested.
Comment 3 Florian Müllner 2016-12-17 17:41:30 UTC 
Review of attachment 342123 [details] [review]:

LGTM
Comment 4 Alan Coopersmith 2017-02-10 07:51:06 UTC 
I don't have gnome.org commit access - how do we proceed to get this pushed?
Comment 5 Florian Müllner 2017-02-10 10:25:38 UTC 
(In reply to Alan Coopersmith from comment #4)
> I don't have gnome.org commit access - how do we proceed to get this pushed?

Telling us that you need someone to push the patch for you is usually enough; pushed as ddfdfaed785e.