After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776020 - tests: Minor leak and error handling fixes
tests: Minor leak and error handling fixes
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-12 22:14 UTC by Philip Withnall
Modified: 2016-12-19 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Fix a missing error handling block (868 bytes, patch)
2016-12-12 22:14 UTC, Philip Withnall 		committed Details | Review
tests: Fix a leak on an error path (728 bytes, patch)
2016-12-12 22:14 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2016-12-12 22:14:37 UTC 
A few small fixes spotted by Coverity.
Comment 1 Philip Withnall 2016-12-12 22:14:41 UTC 
Created attachment 341850 [details] [review]
tests: Fix a missing error handling block

err could never be set here, meaning we were missing out on some error
checking. The test still passes.

Coverity CID 1388525.
Comment 2 Philip Withnall 2016-12-12 22:14:44 UTC 
Created attachment 341851 [details] [review]
tests: Fix a leak on an error path

Inconsequential leak fix.

Coverity CID 1388539.
Comment 3 Bastien Nocera 2016-12-19 17:49:01 UTC 
Attachment 341850 [details] pushed as b2b23b0 - tests: Fix a missing error handling block
Attachment 341851 [details] pushed as 28b2aff - tests: Fix a leak on an error path