After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775848 - plugins: enable direct rendering through environment variable
plugins: enable direct rendering through environment variable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other All
: Normal normal
: 1.11.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-08 17:57 UTC by Víctor Manuel Jáquez Leal
Modified: 2017-04-12 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
plugins: enable direct rendering with envvar (2.13 KB, patch)
2016-12-08 17:57 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-12-08 17:57:26 UTC
see commit message
Comment 1 Víctor Manuel Jáquez Leal 2016-12-08 17:57:31 UTC
Created attachment 341641 [details] [review]
plugins: enable direct rendering with envvar

Direct rendering (use vaDeriveImage rather than vaPutImage) has better
performance in some Intel platforms (Haswell, for example) but in others
(Skylake) is the opposite.

In order to have some control, the patch enables the direct rendering
through the environment variable GST_VAAPI_ENABLE_DIRECT_RENDERING.
Comment 2 Sebastian Dröge (slomo) 2016-12-08 18:01:50 UTC
Can't this be autodetected based on what hardware it runs on? Environment variables are not very useful...
Comment 3 Víctor Manuel Jáquez Leal 2016-12-08 18:13:35 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> Can't this be autodetected based on what hardware it runs on? Environment
> variables are not very useful...

The real fix should be in the intel's driver, because in theory the VA-API should unburden us of these issues, but that's never is the case. So, I don't know...
Comment 4 Víctor Manuel Jáquez Leal 2017-04-12 18:52:57 UTC
Comment on attachment 341641 [details] [review]
plugins: enable direct rendering with envvar

as it is also affecting gallium/radeon driver, let's push it. The world is not ready for direct rendering by default :D
Comment 5 Víctor Manuel Jáquez Leal 2017-04-12 18:53:30 UTC
commit 24af97a7d106c1ba7cd1fe607e427f728ab9cf9c