After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775796 - value: add intersection/union/is_subset/fixate implementations
value: add intersection/union/is_subset/fixate implementations
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-08 10:17 UTC by Matthew Waters (ystreet00)
Modified: 2016-12-15 03:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
value: add structure instersect/union/is_subset/fixate implementations (15.37 KB, patch)
2016-12-08 10:18 UTC, Matthew Waters (ystreet00) 		none Details | Review
value: add structure instersect/union/is_subset/fixate implementations (14.89 KB, patch)
2016-12-08 10:19 UTC, Matthew Waters (ystreet00) 		committed Details | Review

Description Matthew Waters (ystreet00) 2016-12-08 10:17:15 UTC 
See commit message.
Comment 1 Matthew Waters (ystreet00) 2016-12-08 10:18:47 UTC 
Created attachment 341601 [details] [review]
value: add structure instersect/union/is_subset/fixate implementations
Comment 2 Matthew Waters (ystreet00) 2016-12-08 10:19:52 UTC 
Created attachment 341602 [details] [review]
value: add structure instersect/union/is_subset/fixate implementations
Comment 3 Sebastian Dröge (slomo) 2016-12-08 11:34:13 UTC 
Review of attachment 341602 [details] [review]:

The sentence in the commit message is cut off. "Subtraction is not implemented as when ..."
Comment 4 Matthew Waters (ystreet00) 2016-12-15 03:00:29 UTC 
commit ad40c5cd365eceadff867ab489a85ef7f2ed6c05
Author: Matthew Waters <matthew@centricular.com>
Date:   Thu Dec 8 21:01:52 2016 +1100

    value: add structure intersect/union/is_subset/fixate implementations
    
    Allows proper usage of structures in structures in caps.  Subtraction
    is not implemented due to complications with empty fields representing
    all possible values.
    
    The only implementation that doesn't delegate to the already existing
    GstStructure functions is the union function.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775796