After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775702 - v4l2object: Don't set empty interlace-mode list
v4l2object: Don't set empty interlace-mode list
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-06 12:16 UTC by Arun Raghavan
Modified: 2017-02-22 09:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2object: Don't set empty interlace-mode list (1.24 KB, patch)
2016-12-06 12:17 UTC, Arun Raghavan 		committed Details | Review

Description Arun Raghavan 2016-12-06 12:16:59 UTC 
Attached patch explains the failure case and the fix.
Comment 1 Arun Raghavan 2016-12-06 12:17:06 UTC 
Created attachment 341474 [details] [review]
v4l2object: Don't set empty interlace-mode list

If for some reason we fail to probe formats (all try_fmt calls fail, for
example), this is not a critical error, but we end up with an empty list
of interlace modes. This causes all subsequent negotiation to fail.

This patch fixes interlace-mode setting to be skipped if we failed to
detect any.
Comment 2 Nicolas Dufresne (ndufresne) 2016-12-06 16:29:42 UTC 
Review of attachment 341474 [details] [review]:

Looks good. Do you have a reference of which hardware/driver this happened on ?
Comment 3 Arun Raghavan 2016-12-07 03:19:50 UTC 
This is on an odroid xu4. I still don't have it working atm, because the final S_FMT fails with an EINVAL, but at least I'm past the negotiation failure. Will wait to resolve that before pushing this out (maybe the failures are related).
Comment 4 Arun Raghavan 2016-12-08 04:36:46 UTC 
The problem turned out to be with libv4l2 (possibly a bad build in Fedora packages). The fix isn't required on my build any more, but it's still correct IMO, so will push it out.
Comment 5 Arun Raghavan 2016-12-08 04:44:34 UTC 
Attachment 341474 [details] pushed as 1ea9735 - v4l2object: Don't set empty interlace-mode list
Comment 6 Nicolas Dufresne (ndufresne) 2016-12-08 20:11:14 UTC 
Indeed, the fix it totally correct, thanks.
Comment 7 Nicolas Dufresne (ndufresne) 2017-02-22 09:14:50 UTC 
In 1.10 as 1f38e00be92589d03a3558b2fd2c6eecbf7ae535
Comment 8 Nicolas Dufresne (ndufresne) 2017-02-22 09:21:00 UTC 
Wrong ref, 1.10 as d4afc3bc5be9b6b6d374af0b3dcbd6f8ff8a687d