After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775524 - [PATCHES] NEWS: Fix typos and wrong/inconsistent capitalisation
[PATCHES] NEWS: Fix typos and wrong/inconsistent capitalisation
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.22.x
Other Windows
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-02 15:30 UTC by Daniel Boles
Modified: 2016-12-13 09:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH 1/4] NEWS: Fix typos in 3.22.3 section (1.06 KB, patch)
2016-12-02 15:30 UTC, Daniel Boles
committed Details | Review
[PATCH 2/4] NEWS: Clarify one line in 3.22.3 section (929 bytes, patch)
2016-12-02 15:31 UTC, Daniel Boles
committed Details | Review
[PATCH 3/4] NEWS: Fix an older typo (752 bytes, patch)
2016-12-02 15:32 UTC, Daniel Boles
committed Details | Review
[PATCH 4/4] NEWS: Fix/unify various capitalisations (16.05 KB, patch)
2016-12-02 15:34 UTC, Daniel Boles
none Details | Review
[PATCH 4/4] NEWS: Fix/unify various capitalisations (16.05 KB, patch)
2016-12-02 15:37 UTC, Daniel Boles
committed Details | Review
yet more... (6.17 KB, patch)
2016-12-03 02:09 UTC, Daniel Boles
committed Details | Review

Description Daniel Boles 2016-12-02 15:30:14 UTC
Created attachment 341246 [details] [review]
[PATCH 1/4] NEWS: Fix typos in 3.22.3 section

I noticed some typos in the 3.22.3 announcement and decided to take a closer look, finding some other (I hope!) improvements to make. Even though these are trivial, I thought I'd double-check before committing. :)
Comment 1 Daniel Boles 2016-12-02 15:31:44 UTC
Created attachment 341247 [details] [review]
[PATCH 2/4] NEWS: Clarify one line in 3.22.3 section

> Wording made me do a double-take; other readers might do too.
Comment 2 Daniel Boles 2016-12-02 15:32:14 UTC
Created attachment 341248 [details] [review]
[PATCH 3/4] NEWS: Fix an older typo

It's it's versus its again
Comment 3 Daniel Boles 2016-12-02 15:34:20 UTC
Created attachment 341249 [details] [review]
[PATCH 4/4] NEWS: Fix/unify various capitalisations

> e.g. flatpak => Flatpak, ctrl => Ctrl, various acronyms, etc.
Comment 4 Daniel Boles 2016-12-02 15:37:11 UTC
Created attachment 341250 [details] [review]
[PATCH 4/4] NEWS: Fix/unify various capitalisations

> e.g. flatpak => Flatpak, ctrl => Ctrl, various acronyms, etc.
Comment 5 sébastien lafargue 2016-12-02 15:37:24 UTC
Review of attachment 341246 [details] [review]:

LGTM
Comment 6 sébastien lafargue 2016-12-02 15:38:48 UTC
Review of attachment 341247 [details] [review]:

hmm, any reason to change that ?
Comment 7 sébastien lafargue 2016-12-02 15:39:28 UTC
Review of attachment 341248 [details] [review]:

LGTM
Comment 8 Daniel Boles 2016-12-02 15:42:51 UTC
(In reply to sébastien lafargue from comment #6)
> Review of attachment 341247 [details] [review] [review]:
> 
> hmm, any reason to change that ?

I don't know if it really matters... as maybe I'm the only person who had to think for a split second more when reading that line. :) Maybe I've made so many typos where random punctuation has appeared, that I like to make it clear that I intended to write them, by putting in 'the ; character' or quotes or something. ;)
Comment 9 sébastien lafargue 2016-12-02 15:43:36 UTC
Review of attachment 341250 [details] [review]:

LGTM
Comment 10 sébastien lafargue 2016-12-02 15:45:49 UTC
Review of attachment 341247 [details] [review]:

LGTM
Comment 11 Daniel Boles 2016-12-02 19:44:42 UTC
Thanks for the reviews. Since the commits are quite trivial, would you like me to squash any of them first or just push as-is?
Comment 12 sébastien lafargue 2016-12-02 20:47:16 UTC
yeah, same file too, you can pack them in one and push, thanks
Comment 13 Daniel Boles 2016-12-02 21:31:00 UTC
Done, cheers!
Comment 14 Daniel Boles 2016-12-03 02:09:10 UTC
Created attachment 341289 [details] [review]
yet more...

I noticed a few more when looking at the committed diff - posting in case useful.

After this one, I'll just make a pledge never to read the file again, and stop bugging you with trivial commits, and hopefully do something useful instead. :)
Comment 15 sébastien lafargue 2016-12-13 09:54:54 UTC
Review of attachment 341289 [details] [review]:

commited as 877dce0