GNOME Bugzilla – Bug 774944
iqa makes it difficult to support multiple metrics
Last modified: 2018-11-03 13:59:41 UTC
This was discussed on the IRC, the gist is that iqa hardcodes all input to be converted to RGB for dssim, and not all metrics can be computed on RGB. One possible fix is to make existing Iqa class a dssim-only class (renaming it to IqaDssim), and implement other metrics as separate IqaSomething classes. Not a lot of code duplication, since GstVideoAggregator does most of the plumbing anyway.
Created attachment 340621 [details] [review] IQA: Rename iqa element to iqadssim Remove do-dssim property, as iqadssim only ever does dssim metric. Make iqadssim compilation conditional on the dssim presence.
attachment 340621 [details] [review] does not include meson changes, as my meson-fu is a bit weak.
I disagree with this patch. My intention with this plugin was to provide the ability to run multiple metrics at once, and emit a single message for all the pads and all the metrics for a set of frames. Can you explain how you would do this with the proposed approach?
The current implementation isn't flexible on the pixel format and I don't see how this can be fixed. Having multiple elements with a clear naming convention is a fair workaround to that.
From IRC: <ndufresne> note, I didn't look at what it would be to move from VideoAggregator to Aggregator itself <ndufresne> we could do the format conversion when needed, as needed <ndufresne> (this is a suggestion from ocrete) <ndufresne> from there you accept anything on your input, and in the aggregate funciton, you'll get that original image, which is better when always having a converted image I'd be way more interested to see this happen.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/479.