After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774925 - HTTPS Everywhere breaks planet.gnome.org
HTTPS Everywhere breaks planet.gnome.org
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-23 15:15 UTC by Michael Catanzaro
Modified: 2016-11-23 22:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Decide on which URI tests to use in web process (2.45 KB, patch)
2016-11-23 22:44 UTC, Michael Catanzaro
committed Details | Review
web-extension: Avoid potential HTTPS Everywhere redirect loop (3.39 KB, patch)
2016-11-23 22:44 UTC, Michael Catanzaro
committed Details | Review
Allow web extension to control tests performed by URI tester (9.82 KB, patch)
2016-11-23 22:44 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2016-11-23 15:15:19 UTC
It redirects http://planet.gnome.org -> https://planet.gnome.org and the server redirects back to HTTP, we get a loop and load fails.

This is of course incredibly dumb -- planet.gnome.org should just remove non-HTTPS planets -- but it could happen on other sites and we need to avoid it.

I guess we need to track previous provisional loads in the web extension.
Comment 1 Michael Catanzaro 2016-11-23 22:44:46 UTC
The following fixes have been pushed:
824a1c0 Decide on which URI tests to use in web process
c7798b6 web-extension: Avoid potential HTTPS Everywhere redirect loop
0e0a95b Allow web extension to control tests performed by URI tester
Comment 2 Michael Catanzaro 2016-11-23 22:44:49 UTC
Created attachment 340652 [details] [review]
Decide on which URI tests to use in web process

Since the HTTPS Everywhere decision has to be made here, let's do the
rest here as well.
Comment 3 Michael Catanzaro 2016-11-23 22:44:53 UTC
Created attachment 340653 [details] [review]
web-extension: Avoid potential HTTPS Everywhere redirect loop

When a particularly stupid server decides to redirect from an https://
URI to an http:// URI (this should never be done) and we also happen to
have an incorrect HTTPS Everywhere rule to redirect from http:// to
https:// for that URI, we get into a redirect loop and the load fails.
Check for this condition and avoid using HTTPS Everywhere in this case.
Comment 4 Michael Catanzaro 2016-11-23 22:44:57 UTC
Created attachment 340654 [details] [review]
Allow web extension to control tests performed by URI tester

So we can selectively disable HTTPS Everywhere