After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774791 - return value of ElementFactory.get_static_pad_templates should be "unowned"
return value of ElementFactory.get_static_pad_templates should be "unowned"
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GTK+ GStreamer WebKitGTK+
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-21 15:58 UTC by Jens Georg
Modified: 2016-11-21 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstreamer-1.0: Make ElementFactory.get_static_pad_templates fully "unowned" (1.61 KB, patch)
2016-11-21 17:02 UTC, Rico Tzschichholz 		committed Details | Review

Description Jens Georg 2016-11-21 15:58:03 UTC 
According to the C api, the return value is transfer none, and I run into a double/invalid free if I try to use the API
Comment 2 Rico Tzschichholz 2016-11-21 17:02:09 UTC 
Created attachment 340456 [details] [review]
gstreamer-1.0: Make ElementFactory.get_static_pad_templates fully "unowned"
Comment 3 Al Thomas 2016-11-21 17:07:42 UTC 
The .metadata was changed to make ElementFactory.get_static_pad_templates unowned with this patch:
https://git.gnome.org/browse/vala/commit/vapi/metadata/Gst-1.0.metadata?id=871cf22610d7869afa90c64a014da9bcebcd620f
after this bug report:
https://bugzilla.gnome.org/show_bug.cgi?id=720694

Then it is changed to ElementFactory.get_static_pad_templates type="GLib.List<weak Gst.StaticPadTemplate?> with this commit:
https://git.gnome.org/browse/vala/commit/vapi/metadata/Gst-1.0.metadata?id=6296d34707d0053919d9496b5cf6c50149fea702

Not sure why that would be.
Comment 4 Rico Tzschichholz 2016-11-21 17:08:17 UTC 
Attachment 340456 [details] pushed as f91f13a - gstreamer-1.0: Make ElementFactory.get_static_pad_templates fully "unowned"