GNOME Bugzilla – Bug 774730
[review] bg/ciphers-case-bgo774730 - ovpn file port and cipher import
Last modified: 2018-01-04 18:51:18 UTC
I'm importing ovpn files into NM (1.4.2). The files contain the following lines: remote area.server.com 1196 cipher aes-128-cbc But upon import into NM (through Add... > Import a saved VPN connection), the port is instead appended to the gateway address (area.server.com:1196) instead of put in (Advanced > General > Use custom gateway port) and the cipher is set to Default instead of the one specified (in Advanced > Security > Cipher). Is there a reason why these fields aren't completely assimilated on import? Let me know if you need more info, but I imagine it's a simple import script fix.
Another one—the conf file contains `auth sha1`, which should change the HMAC Authentication (Advanced > Security > HMAC Authentication) to SHA-1, but the setting remains as "Default".
(In reply to wolf from comment #0) > I'm importing ovpn files into NM (1.4.2). The files contain the following > lines: > > remote area.server.com 1196 > cipher aes-128-cbc > > But upon import into NM (through Add... > Import a saved VPN connection), > the port is instead appended to the gateway address (area.server.com:1196) > instead of put in (Advanced > General > Use custom gateway port) I think this is correct, 'area.server.com:1196' is the syntax to set a remote-specific port, and the 'custom gateway port' applies only to remotes that don't explicitly specify a port. > and the > cipher is set to Default instead of the one specified (in Advanced > > Security > Cipher). Is there a reason why these fields aren't completely > assimilated on import? Let me know if you need more info, but I imagine it's > a simple import script fix. (In reply to wolf from comment #1) > Another one—the conf file contains `auth sha1`, which should change the HMAC > Authentication (Advanced > Security > HMAC Authentication) to SHA-1, but the > setting remains as "Default". Thanks for reporting these bugs. I've pushed some fixes to branch bg/ciphers-case-bgo774730.
Thanks! (In reply to Beniamino Galvani from comment #2) > the 'custom gateway port' applies only to remotes that don't explicitly specify a port What is the proper syntax for setting the custom gateway port if not with the colon?
(In reply to wolf from comment #3) > What is the proper syntax for setting the custom gateway port if not with > the colon? remote area.server.com port 777
lgtm. Maybe use g_ascii_strcasecmp() instead of the local dependent strcasecmp().
(In reply to Thomas Haller from comment #5) > lgtm. > > Maybe use g_ascii_strcasecmp() instead of the local dependent strcasecmp(). Updated and merged: https://git.gnome.org/browse/network-manager-openvpn/commit/?id=912c0ee3c3f4add1432607da38794ad1d8a59c98
*** Bug 791881 has been marked as a duplicate of this bug. ***