GNOME Bugzilla – Bug 774484
videodecoder, audiodecoder: parse format before checking in src_query_default
Last modified: 2016-11-15 23:13:35 UTC
The logic change in this commit misordered the parsing and checking of format in position queries: 1840b02 audio: Don't answer BYTES queries
Created attachment 339953 [details] [review] [PATCH gst-plugins-base] audiodecoder: parse format before checking in src_query_default
Created attachment 339954 [details] [review] [PATCH gst-plugins-base v2] videodecoder, audiodecoder: parse format before checking in src_query_default
Thanks! Not entirely sure why gcc didn't warn me about such an obvious use of uninitialised variable though :-/ commit e740103669b739f1f43879ff683125b0c0b557c2 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Tue Nov 15 09:32:24 2016 -0800 videodecoder, audiodecoder: parse format before checking in src_query_default The logic change in these commits misordered the parsing and checking of format in position queries: 2b06e54 videodecoder: Don't answer BYTES queries 1840b02 audio: Don't answer BYTES queries https://bugzilla.gnome.org/show_bug.cgi?id=774484
(In reply to Jan Schmidt from comment #3) > Thanks! Not entirely sure why gcc didn't warn me about such an obvious use > of uninitialised variable though :-/ I spent some time puzzling over that and I think that it is a gcc bug. I've filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78370 for this.